From: Jiri Kosina <jikos@kernel.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-usb <linux-usb@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
Hillf Danton <hdanton@sina.com>
Subject: Re: [PATCH 1/1] HID: hiddev: remove a duplicated check
Date: Tue, 14 Jan 2020 15:19:25 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2001141518000.31058@cbobk.fhfr.pm> (raw)
In-Reply-To: <50fd522f-e276-420c-3c6a-0f193bc16ca2@huawei.com>
On Tue, 14 Jan 2020, Leizhen (ThunderTown) wrote:
> Does no one pay attention to this problem? Although there is no
> functional problem, but it seems confusing.
>
> if (!list->hiddev->exist) { <---------
> res = -ENODEV; |
> goto bail_unlock; |
> } |
> if (!list->hiddev->open++) |
> if (list->hiddev->exist) { <--------- //It's always true.
This code no longer exists after refactoring that happened in commit
18a1b06e5b91d47.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-01-14 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 3:51 [PATCH 1/1] HID: hiddev: remove a duplicated check Zhen Lei
2020-01-14 9:16 ` Leizhen (ThunderTown)
2020-01-14 14:19 ` Jiri Kosina [this message]
2020-01-15 2:58 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2001141518000.31058@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hdanton@sina.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).