From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 364B4C31E5B for ; Wed, 19 Jun 2019 00:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F150F2085A for ; Wed, 19 Jun 2019 00:30:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="jJout8Dl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726181AbfFSAa2 (ORCPT ); Tue, 18 Jun 2019 20:30:28 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:47594 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbfFSAa2 (ORCPT ); Tue, 18 Jun 2019 20:30:28 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5J0P5rN178863; Wed, 19 Jun 2019 00:29:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=tCFxvQTSWiPwXiY1UI1u6Ap1gLteDima4HMw6mezFSg=; b=jJout8DlUn5+fA6KgALWZKzp34qP+ePdeXbW8t1171VAmW6efPHe0QUFm/CbsIe4ATDf zrxBE7rr3Z8qwd08CP1zvtNP4kwXkuN5xWm273tSA4xIkQEwcLOLoFYYcxeffrTwkeJa zlvYq+mMqfHI0WaEmbCfq17SQG0Cdg2VyzD6ZMIJIf3unMgqxO81EI3yE+3IVtluN8zB ApiLMJZNAMzwIQQFK8btuQizXAMagIPt1Lv/VAP2hpeBH8foJpHd1Gv1YXkdVHgX0v6l dat3Hu5pXQ01I8YFw0GSnuNfbWYHXvQ6dnj8FacVYRUVMbhYa2fBcKnDbJBJFiaXFiqX LA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2t78098dhf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2019 00:29:17 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5J0SRhL046424; Wed, 19 Jun 2019 00:29:16 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2t77ynhn1v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2019 00:29:16 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5J0T7J9013561; Wed, 19 Jun 2019 00:29:07 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 18 Jun 2019 17:29:06 -0700 To: Ming Lei Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , James Bottomley , Bart Van Assche , Hannes Reinecke , Christoph Hellwig , Jim Gill , Cathy Avery , "Ewan D . Milne" , Brian King , James Smart , "Juergen E . Fischer" , Michael Schmitz , Finn Thain , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, Dan Carpenter , Benjamin Block Subject: Re: [PATCH V5 00/16] use sg helper to operate scatterlist From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190618013757.22401-1-ming.lei@redhat.com> Date: Tue, 18 Jun 2019 20:29:02 -0400 In-Reply-To: <20190618013757.22401-1-ming.lei@redhat.com> (Ming Lei's message of "Tue, 18 Jun 2019 09:37:41 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9292 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=573 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906190001 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9292 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=627 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906190001 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Ming, > So convert drivers to use scatterlist helper. I applied this series with a bunch of edits and clarifying comments. It was quite the nightmare to rebase 5.3/scsi-queue to satisfy the ordering requirements, locate the scattered fixes, tweak tags, etc. Hope I got everything right. It was almost at the point where I gave up and postponed everything to 5.4. We're at -rc5 -- it's not exactly a good time to rebase the entire tree. However, I know the static mq allocations are causing headaches for several distro vendors so I begrudgingly bit the bullet. I would have liked to see more reviews from the official driver maintainers but at the same time I didn't want to wait any longer giving this some soak time in linux-next. Thanks for your work on getting all the drivers fixed up! Just goes to show how large the fallout can be from a relatively innocuous core change. Oh, and I held back the rtsx patch due to lack of reviews. But since that driver is in staging I'm not too worried about it. Hope we can get the fix for that reviewed and merged soon. -- Martin K. Petersen Oracle Linux Engineering