From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE8EDC5DF64 for ; Wed, 6 Nov 2019 04:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82298217F4 for ; Wed, 6 Nov 2019 04:31:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="KOzxI+wH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731240AbfKFEbl (ORCPT ); Tue, 5 Nov 2019 23:31:41 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:53488 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbfKFEbl (ORCPT ); Tue, 5 Nov 2019 23:31:41 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA64Sqli082794; Wed, 6 Nov 2019 04:31:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=/ZtPK4ZzB/bJ4YHeBLzDhoB9Htw2t7HAj0EdVtIAxYs=; b=KOzxI+wHrJmkXUlq4JRGQMqUME1PSKA4AB/wK8cxpLpgjR4Dc25QVtcAcp0vtTlQA6c6 NpAI51zzWsKOH8gz63vCyNMi/1GS5LRPsv8eyOzAQWuyMLrxmyEXa7kUsOl72idfah0f tQWciEGUVics40iEKHeSqP1XhHOORDlfF4T5KtMbjiv0xpd+GGwSfUgWQs9VWQP7rdwg yOkBM2t/4JG5kBVEnWX4awQIwGOBPHPnD+67gBWou7wrRbaqa5VhLfZvk160vao0qmnw VyR4i/7PKP34Va0znPpKIEoIFkbPMXNqrsJyWTo+HchCKjuGmxtILHIdK0hiFh+YKyA7 8Q== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2w11rq32m8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Nov 2019 04:31:22 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA64Spdu006375; Wed, 6 Nov 2019 04:31:22 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2w35pq6xsq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Nov 2019 04:31:21 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA64VFSn001743; Wed, 6 Nov 2019 04:31:15 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Nov 2019 20:31:15 -0800 To: Damien Le Moal Cc: "Martin K. Petersen" , Hannes Reinecke , Bart Van Assche , "linux-scsi\@vger.kernel.org" , "linux-usb\@vger.kernel.org" , "usb-storage\@lists.one-eyed-alien.net" , Alan Stern , Greg Kroah-Hartman , Justin Piszcz Subject: Re: [PATCH v2] scsi: Fix scsi_get/set_resid() interface From: "Martin K. Petersen" Organization: Oracle Corporation References: <20191030090847.25650-1-damien.lemoal@wdc.com> Date: Tue, 05 Nov 2019 23:31:12 -0500 In-Reply-To: (Damien Le Moal's message of "Tue, 5 Nov 2019 05:24:04 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9432 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=513 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911060046 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9432 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=593 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911060046 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Damien, > Or keeping resid_len as an unsigned int and adding a flag specifying > if the value means underflow or overflow ? It's been broken for so long I'd rather make the overflow case an opt-in. So a separate flag, please. -- Martin K. Petersen Oracle Linux Engineering