From: Guenter Roeck <linux@roeck-us.net>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: "Martin Hundebøll" <martin@geanix.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCHv2] rtc: pcf2127: handle boot-enabled watchdog feature
Date: Mon, 7 Oct 2019 05:31:54 -0700 [thread overview]
Message-ID: <036e1e1d-1925-b003-8fb4-d568ae066d44@roeck-us.net> (raw)
In-Reply-To: <CAH+2xPDkezVexmJRcuMmZ-vFbmw6CjDn3k4_SUNw_FNzy93AgQ@mail.gmail.com>
On 10/7/19 3:49 AM, Bruno Thomsen wrote:
> Hi Guenter & Martin
>
> Den søn. 6. okt. 2019 kl. 18.19 skrev Guenter Roeck <linux@roeck-us.net>:
>>>>
>>>> This should not be decided on driver level. The intended means to
>>>> enforce
>>>> an initial timeout would be to set CONFIG_WATCHDOG_OPEN_TIMEOUT, or to
>>>> use
>>>> the open_timeout kernel parameter.
>>>
>>> That, and WATCHDOG_HANDLE_BOOT_ENABLED
>>>
>>
>> To clarify: If WATCHDOG_HANDLE_BOOT_ENABLED is disabled, the watchdog core
>> does not ping the watchdog on its own, and Bruno's argument does not apply
>> in the first place.
>
> Thanks for clarifying.
>
> When reading the WDOG_HW_RUNNING bit description in kernel api [1]
> documentation around line 247 you don't get the impression that the behavior
> can be modified by 2 Kconfig options and 1 runtime option. Maybe add an
> additional note?
>
That is probably because the two configuration options were added later
and the documentation was not updated. Patches welcome.
Guenter
> I am overall okay with the change, but I have a few extra comments.
>
> If the dev_err message is kept there is a typo in register name: wd_val.
>
> The variable name wdd_timeout is a bit misleading as the register does not
> contain the initial timeout value but a countdown value, ex. wdd_value.
>
> Bruno
>
> [1] Documentation/watchdog/watchdog-kernel-api.rst
>
next prev parent reply other threads:[~2019-10-07 12:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 12:48 [PATCH] rtc: pcf2127: handle boot-enabled watchdog feature Martin Hundebøll
2019-10-03 13:05 ` Guenter Roeck
2019-10-03 13:27 ` Martin Hundebøll
2019-10-03 13:56 ` Guenter Roeck
2019-10-03 13:33 ` [PATCHv2] " Martin Hundebøll
2019-10-03 13:57 ` Guenter Roeck
2019-10-03 21:44 ` Alexandre Belloni
2019-10-06 9:07 ` Bruno Thomsen
2019-10-06 14:29 ` Guenter Roeck
2019-10-06 15:58 ` Martin Hundebøll
2019-10-06 16:19 ` Guenter Roeck
2019-10-07 10:49 ` Bruno Thomsen
2019-10-07 12:31 ` Guenter Roeck [this message]
2019-10-21 8:08 ` [PATCHv3] " Martin Hundebøll
2019-10-21 8:33 ` Alexandre Belloni
2019-10-21 16:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=036e1e1d-1925-b003-8fb4-d568ae066d44@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bruno.thomsen@gmail.com \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=martin@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).