From: Guenter Roeck <linux@roeck-us.net>
To: Tian Tao <tiantao6@hisilicon.com>, wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: ziirave_wdt: remove unused including <linux/version.h>
Date: Fri, 25 Dec 2020 06:19:20 -0800 [thread overview]
Message-ID: <0887f9dc-2500-6788-a4a4-4c187c865395@roeck-us.net> (raw)
In-Reply-To: <1608886154-55309-1-git-send-email-tiantao6@hisilicon.com>
On 12/25/20 12:49 AM, Tian Tao wrote:
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/ziirave_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index cab86a0..4297280 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -18,7 +18,6 @@
> #include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/types.h>
> -#include <linux/version.h>
> #include <linux/watchdog.h>
>
> #include <asm/unaligned.h>
>
prev parent reply other threads:[~2020-12-25 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 8:49 [PATCH] watchdog: ziirave_wdt: remove unused including <linux/version.h> Tian Tao
2020-12-25 14:19 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0887f9dc-2500-6788-a4a4-4c187c865395@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).