Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] watchdog: use boolean value when setting nowayout
@ 2020-12-29 11:19 Tian Tao
  2020-12-29 16:04 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-12-29 11:19 UTC (permalink / raw)
  To: wim, linux; +Cc: linux-watchdog

Fixes coccicheck warnings:
drivers/watchdog/alim7101_wdt.c:390:2-10: WARNING: Assignment of 0/1 to
bool variable

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/watchdog/alim7101_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
index 4ff7f5a..951449e 100644
--- a/drivers/watchdog/alim7101_wdt.c
+++ b/drivers/watchdog/alim7101_wdt.c
@@ -387,7 +387,7 @@ static int __init alim7101_wdt_init(void)
 			pr_info("Detected old alim7101 revision 'a1d'.  If this is a cobalt board, set the 'use_gpio' module parameter.\n");
 			goto err_out;
 		}
-		nowayout = 1;
+		nowayout = true;
 	} else if ((tmp & 0x1e) != 0x12 && (tmp & 0x1e) != 0x00) {
 		pr_info("ALi 1543 South-Bridge does not have the correct revision number (???1001?) - WDT not set\n");
 		goto err_out;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: use boolean value when setting nowayout
  2020-12-29 11:19 [PATCH] watchdog: use boolean value when setting nowayout Tian Tao
@ 2020-12-29 16:04 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-12-29 16:04 UTC (permalink / raw)
  To: Tian Tao, wim; +Cc: linux-watchdog

On 12/29/20 3:19 AM, Tian Tao wrote:
> Fixes coccicheck warnings:
> drivers/watchdog/alim7101_wdt.c:390:2-10: WARNING: Assignment of 0/1 to
> bool variable
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>  drivers/watchdog/alim7101_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
> index 4ff7f5a..951449e 100644
> --- a/drivers/watchdog/alim7101_wdt.c
> +++ b/drivers/watchdog/alim7101_wdt.c
> @@ -387,7 +387,7 @@ static int __init alim7101_wdt_init(void)
>  			pr_info("Detected old alim7101 revision 'a1d'.  If this is a cobalt board, set the 'use_gpio' module parameter.\n");
>  			goto err_out;
>  		}
> -		nowayout = 1;
> +		nowayout = true;
>  	} else if ((tmp & 0x1e) != 0x12 && (tmp & 0x1e) != 0x00) {
>  		pr_info("ALi 1543 South-Bridge does not have the correct revision number (???1001?) - WDT not set\n");
>  		goto err_out;
> 

This driver would benefit from conversion to use the watchdog subsystem,
but it doesn't benefit from cosmetic changes. For the record, I am not
going to accept cosmetic changes to watchdog drivers unless they use
the watchdog subsystem.

As a general comment, please list the driver name in the subject of your
patches.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 11:19 [PATCH] watchdog: use boolean value when setting nowayout Tian Tao
2020-12-29 16:04 ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git