From: Xingyu Chen <xingyu.chen@amlogic.com>
To: Julius Werner <jwerner@chromium.org>
Cc: Evan Benn <evanbenn@chromium.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
<linux-watchdog@vger.kernel.org>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Yonghui Yu <yonghui.yu@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible
Date: Sat, 22 Feb 2020 12:01:24 +0800
Message-ID: <1326f594-3cfd-c03d-4f2c-50eeb75724b2@amlogic.com> (raw)
In-Reply-To: <CAODwPW94KX46PzSrf_uuEFPKudXor=26d=g3Qta5veRfxmMDUA@mail.gmail.com>
Hi, Julius
On 2020/2/22 3:41, Julius Werner wrote:
>> Because the ATF does not define standard wdt index, each vendor defines
>> its own index.
>> So I don't think that the current driver[0] can fully cover my usecases.
> I think the best way to solve this would be to put the SMC function ID
> as another field into the device tree, so that multiple vendors could
> share the same driver even if their firmware interface uses a
> different SMC. But they still have to implement the same API for that
> SMC, of course, not sure if the Meson driver is suitable for that (but
> if it is then I think merging those drivers would be a good idea).
The SMC function ID may be solved by the DTS, but the wdt indexs(Eg:
SMCWD_INFO) are also different
for each vendor. The imx_sc_wdt.c is also use the SMC to operate the
WDT, but the wdt indexs(Eg: IMX_SIP_TIMER_START_WDOG)
are different from ours. IMO, If the ATF can implement a common hal
interface and index for watchdog, then writing a
common smc wdt driver will be easier to compatible with all vendors.
Best Regards
>
> .
next prev parent reply index
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 6:26 [PATCH 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-02-14 6:26 ` [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Evan Benn
2020-02-19 22:30 ` Rob Herring
2020-02-19 23:04 ` Julius Werner
2020-02-19 23:20 ` Guenter Roeck
2020-02-20 6:41 ` Evan Benn
2020-02-20 15:43 ` Guenter Roeck
2020-02-21 15:36 ` Xingyu Chen
2020-02-21 19:41 ` Julius Werner
2020-02-21 20:46 ` Guenter Roeck
2020-02-22 4:01 ` Xingyu Chen [this message]
2020-02-24 1:10 ` Evan Benn
2020-02-25 1:23 ` Julius Werner
2020-02-25 7:44 ` Xingyu Chen
2020-03-10 1:00 ` Evan Benn
[not found] ` <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com>
2020-03-11 19:24 ` Julius Werner
2020-03-13 16:13 ` Xingyu Chen
2020-02-14 6:26 ` [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn
2020-02-14 9:35 ` Enric Balletbo Serra
2020-02-14 14:10 ` Guenter Roeck
2020-02-14 21:32 ` Julius Werner
2020-02-15 1:39 ` Evan Benn
2020-02-20 6:50 ` Evan Benn
2020-02-20 15:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326f594-3cfd-c03d-4f2c-50eeb75724b2@amlogic.com \
--to=xingyu.chen@amlogic.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=evanbenn@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jianxin.pan@amlogic.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yonghui.yu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Watchdog Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
linux-watchdog@vger.kernel.org
public-inbox-index linux-watchdog
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git