From: Crystal Guo <crystal.guo@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"Seiya Wang (王迺君)" <seiya.wang@mediatek.com>,
"Erin Lo (羅雅齡)" <erin.lo@mediatek.com>
Subject: Re: [v2,2/3] dt-bindings: watchdog: add a new head file for toprgu reset-controllers
Date: Wed, 29 Jul 2020 16:35:07 +0800 [thread overview]
Message-ID: <1596011707.11360.9.camel@mhfsdcap03> (raw)
In-Reply-To: <72d317ef-7f69-9e61-b1d5-23d660c58560@gmail.com>
On Wed, 2020-07-29 at 16:15 +0800, Matthias Brugger wrote:
>
> On 29/07/2020 10:11, Crystal Guo wrote:
> > On Wed, 2020-07-29 at 15:42 +0800, Matthias Brugger wrote:
> >> Hi Crystal,
> >>
> >> On 29/07/2020 08:30, Crystal Guo wrote:
> >>> merge all the reset numbers in one head file.
> >>>
> >>> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> >>> ---
> >>> include/dt-bindings/reset-controller/mtk-resets.h | 13 +++++++++++++
> >>> 1 file changed, 13 insertions(+)
> >>> create mode 100644 include/dt-bindings/reset-controller/mtk-resets.h
> >>>
> >>> diff --git a/include/dt-bindings/reset-controller/mtk-resets.h b/include/dt-bindings/reset-controller/mtk-resets.h
> >>> new file mode 100644
> >>> index 0000000..d73a4ba
> >>> --- /dev/null
> >>> +++ b/include/dt-bindings/reset-controller/mtk-resets.h
> >>> @@ -0,0 +1,13 @@
> >>> +/* SPDX-License-Identifier: GPL-2.0 */
> >>> +/*
> >>> + * Copyright (C) 2020 Mediatek Inc.
> >>> + *
> >>> + */
> >>> +
> >>> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MTK
> >>> +#define _DT_BINDINGS_RESET_CONTROLLER_MTK
> >>> +
> >>> +#define MT2712_TOPRGU_SW_RST_NUM 11
> >>> +#define MT8183_TOPRGU_SW_RST_NUM 19
> >>
> >> Maybe I didn't explain myself properly. We want to have all resets in one file
> >> and do not want to have the resets for the watchdog in a different file. That
> >> means I don't thin your patch is correct and the effort should be abandoned.
> >>
> >> Regards,
> >> Matthias
> >
> > Do you mean to keep the current way unchanged? For example, with a new
> > SOC 8192, should add a new head file mt8192_resets.h for the resets
> > numbers.
> >
>
> Exactly.
>
> Regards,
> Matthias
OK, but the dt-binding mtk-wdt.txt still need to update, please help me
to review, many thanks~
next prev parent reply other threads:[~2020-07-29 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 6:30 [v2,0/3] mtk_wdt: merge all the reset numbers in one head file Crystal Guo
2020-07-29 6:30 ` [v2,1/3] dt-bindings: watchdog: modify description for mt2712 and mt8183 Crystal Guo
2020-07-29 6:30 ` [v2,2/3] dt-bindings: watchdog: add a new head file for toprgu reset-controllers Crystal Guo
2020-07-29 7:42 ` Matthias Brugger
2020-07-29 8:11 ` Crystal Guo
2020-07-29 8:15 ` Matthias Brugger
2020-07-29 8:35 ` Crystal Guo [this message]
2020-07-29 6:30 ` [v3,3/3] watchdog: mtk_wdt: merge all the reset numbers in one head file Crystal Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596011707.11360.9.camel@mhfsdcap03 \
--to=crystal.guo@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).