From: Guenter Roeck <linux@roeck-us.net>
To: Hardik Singh Rathore <hardiksingh.k@gmail.com>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Watchdog: remove outdated comment
Date: Sun, 9 Dec 2018 06:13:59 -0800 [thread overview]
Message-ID: <18f7e9ee-0d8f-7c73-cdc0-7826e912d33a@roeck-us.net> (raw)
In-Reply-To: <20181209104726.15610-1-hardiksingh.k@gmail.com>
On 12/9/18 2:47 AM, Hardik Singh Rathore wrote:
> The lock field doesn't exist in watchdog_device structure.
> It was added by commit f4e9c82f64b5 ("watchdog: Add Locking support")
> and removed by commit b4ffb1909843
> ("watchdog: Separate and maintain variables based on variable lifetime")
>
> Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> include/linux/watchdog.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 44985c4a1e86..417d9f37077a 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -90,9 +90,6 @@ struct watchdog_ops {
> *
> * The driver-data field may not be accessed directly. It must be accessed
> * via the watchdog_set_drvdata and watchdog_get_drvdata helpers.
> - *
> - * The lock field is for watchdog core internal use only and should not be
> - * touched.
> */
> struct watchdog_device {
> int id;
>
prev parent reply other threads:[~2018-12-09 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 10:47 [PATCH] Watchdog: remove outdated comment Hardik Singh Rathore
2018-12-09 14:13 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18f7e9ee-0d8f-7c73-cdc0-7826e912d33a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=hardiksingh.k@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).