Linux-Watchdog Archive on lore.kernel.org
 help / Atom feed
* [PATCH] Watchdog: remove outdated comment
@ 2018-12-09 10:47 Hardik Singh Rathore
  2018-12-09 14:13 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Hardik Singh Rathore @ 2018-12-09 10:47 UTC (permalink / raw)
  To: linux; +Cc: wim, linux-watchdog, linux-kernel, Hardik Singh Rathore

The lock field doesn't exist in watchdog_device structure.
It was added by commit f4e9c82f64b5 ("watchdog: Add Locking support")
and removed by commit b4ffb1909843
("watchdog: Separate and maintain variables based on variable lifetime")

Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com>
---
 include/linux/watchdog.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
index 44985c4a1e86..417d9f37077a 100644
--- a/include/linux/watchdog.h
+++ b/include/linux/watchdog.h
@@ -90,9 +90,6 @@ struct watchdog_ops {
  *
  * The driver-data field may not be accessed directly. It must be accessed
  * via the watchdog_set_drvdata and watchdog_get_drvdata helpers.
- *
- * The lock field is for watchdog core internal use only and should not be
- * touched.
  */
 struct watchdog_device {
 	int id;
-- 
2.17.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Watchdog: remove outdated comment
  2018-12-09 10:47 [PATCH] Watchdog: remove outdated comment Hardik Singh Rathore
@ 2018-12-09 14:13 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2018-12-09 14:13 UTC (permalink / raw)
  To: Hardik Singh Rathore; +Cc: wim, linux-watchdog, linux-kernel

On 12/9/18 2:47 AM, Hardik Singh Rathore wrote:
> The lock field doesn't exist in watchdog_device structure.
> It was added by commit f4e9c82f64b5 ("watchdog: Add Locking support")
> and removed by commit b4ffb1909843
> ("watchdog: Separate and maintain variables based on variable lifetime")
> 
> Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   include/linux/watchdog.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 44985c4a1e86..417d9f37077a 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -90,9 +90,6 @@ struct watchdog_ops {
>    *
>    * The driver-data field may not be accessed directly. It must be accessed
>    * via the watchdog_set_drvdata and watchdog_get_drvdata helpers.
> - *
> - * The lock field is for watchdog core internal use only and should not be
> - * touched.
>    */
>   struct watchdog_device {
>   	int id;
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-09 10:47 [PATCH] Watchdog: remove outdated comment Hardik Singh Rathore
2018-12-09 14:13 ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org linux-watchdog@archiver.kernel.org
	public-inbox-index linux-watchdog


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/ public-inbox