linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe()
@ 2020-05-25  7:31 Tiezhu Yang
  2020-05-25 13:47 ` Guenter Roeck
  0 siblings, 1 reply; 3+ messages in thread
From: Tiezhu Yang @ 2020-05-25  7:31 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Florian Fainelli, Ray Jui,
	Scott Branden
  Cc: bcm-kernel-feedback-list, linux-watchdog, linux-kernel,
	Xuefeng Li, Tiezhu Yang

When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 drivers/watchdog/bcm_kona_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c
index eb850a8..8237c4e 100644
--- a/drivers/watchdog/bcm_kona_wdt.c
+++ b/drivers/watchdog/bcm_kona_wdt.c
@@ -279,7 +279,7 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
 
 	wdt->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(wdt->base))
-		return -ENODEV;
+		return PTR_ERR(wdt->base);
 
 	wdt->resolution = SECWDOG_DEFAULT_RESOLUTION;
 	ret = bcm_kona_wdt_set_resolution_reg(wdt);
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe()
  2020-05-25  7:31 [PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe() Tiezhu Yang
@ 2020-05-25 13:47 ` Guenter Roeck
  2020-07-06  8:56   ` Tiezhu Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2020-05-25 13:47 UTC (permalink / raw)
  To: Tiezhu Yang, Wim Van Sebroeck, Florian Fainelli, Ray Jui, Scott Branden
  Cc: bcm-kernel-feedback-list, linux-watchdog, linux-kernel, Xuefeng Li

On 5/25/20 12:31 AM, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/bcm_kona_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c
> index eb850a8..8237c4e 100644
> --- a/drivers/watchdog/bcm_kona_wdt.c
> +++ b/drivers/watchdog/bcm_kona_wdt.c
> @@ -279,7 +279,7 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
>  
>  	wdt->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(wdt->base))
> -		return -ENODEV;
> +		return PTR_ERR(wdt->base);
>  
>  	wdt->resolution = SECWDOG_DEFAULT_RESOLUTION;
>  	ret = bcm_kona_wdt_set_resolution_reg(wdt);
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe()
  2020-05-25 13:47 ` Guenter Roeck
@ 2020-07-06  8:56   ` Tiezhu Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Tiezhu Yang @ 2020-07-06  8:56 UTC (permalink / raw)
  To: Guenter Roeck, Wim Van Sebroeck, Florian Fainelli, Ray Jui,
	Scott Branden
  Cc: bcm-kernel-feedback-list, linux-watchdog, linux-kernel, Xuefeng Li

On 05/25/2020 09:47 PM, Guenter Roeck wrote:
> On 5/25/20 12:31 AM, Tiezhu Yang wrote:
>> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
>> to check the return value and return PTR_ERR() if failed.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Hi,

Could you please apply this patch?

Thanks,
Tiezhu

>
>> ---
>>   drivers/watchdog/bcm_kona_wdt.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c
>> index eb850a8..8237c4e 100644
>> --- a/drivers/watchdog/bcm_kona_wdt.c
>> +++ b/drivers/watchdog/bcm_kona_wdt.c
>> @@ -279,7 +279,7 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
>>   
>>   	wdt->base = devm_platform_ioremap_resource(pdev, 0);
>>   	if (IS_ERR(wdt->base))
>> -		return -ENODEV;
>> +		return PTR_ERR(wdt->base);
>>   
>>   	wdt->resolution = SECWDOG_DEFAULT_RESOLUTION;
>>   	ret = bcm_kona_wdt_set_resolution_reg(wdt);
>>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-06  8:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25  7:31 [PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe() Tiezhu Yang
2020-05-25 13:47 ` Guenter Roeck
2020-07-06  8:56   ` Tiezhu Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).