From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452D3C43331 for ; Fri, 3 Apr 2020 04:07:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06486207FF for ; Fri, 3 Apr 2020 04:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jflbWB9+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbgDCEHb (ORCPT ); Fri, 3 Apr 2020 00:07:31 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:40525 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgDCEHb (ORCPT ); Fri, 3 Apr 2020 00:07:31 -0400 Received: by mail-pl1-f196.google.com with SMTP id h11so2197307plk.7; Thu, 02 Apr 2020 21:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZBjkJKJ5u2z+Q+We6EYzbdq7wJVe06yWFlZX4pTzXxY=; b=jflbWB9+gGGoOHmCUaEOBLFj34cg+V30/HZBeTFc0vAeC/Nqp+9m6We53b/ifWfEje Fgcpei59mxXVlBJfg1rjJcoc5Wwun3dEvEKFB1/1taH7XiNBb36ZIkAye6dNZ71VFKy4 506rjnzjOQe4YdmlrG18YE4K7e7c+FgzRlhdRR0aqD+68DvBcuPhTE9dKCXuTKgLSvAB eDx8FJeOocNOgjO2BNDETJYJKeUqtdxOPEWuSjT4YY5Kf1uoDjexLpe6fbTPtv13MkXw RQsAbwtv60si+Gpih6Glh3SIWU+H+x2QjKdYdCaIMyFc1qJAB4t1ikyeclB1RiUAXgHT WRwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZBjkJKJ5u2z+Q+We6EYzbdq7wJVe06yWFlZX4pTzXxY=; b=fZuaSGWY5DSfSYDGY9C8MAXl1Cyf6SblYLTstDypamK7KnG0/KjYv5+CP7a/zumtP1 8duxBvRSLwxkYDq6GzUjh2j2ycnroxPHZmx80Jjc7qCYTLftM0YeeCD8UbX1CR8oEhNp 3ffTbAbpO5LTwzNSV0QZYke03ZC/4m6XTtTZNSTywThHJlwuIPFa6W+rvii5V38i5Wf6 PaxyfCNyNUeWYS2qRNC0nsEohc+gA41P+vvlh5y3ZDB8f/AumTD0YBkLm/s5eCNFlpzS RyySpQ+E0dHw+JfqXoMrSo5abmHsnAp7D9NEznXjKhUdVlIXLgWm5X34g01fXlVkTlJT V7QQ== X-Gm-Message-State: AGi0PuacoVkbAE6Hr97gNPaQJCiPgyAcZbqHavFK6YI4d8VMfODC4Qh9 5zg7oX7hAoQkRoghvIY2xG53CkxZ X-Google-Smtp-Source: APiQypJshgb3GVfOMqeQAkG1bLCvRzepMFb/Gc8KNNpf+fqtUcos0fQtGxiycuKE6lQrBRAvw8W1zA== X-Received: by 2002:a17:902:9348:: with SMTP id g8mr6155341plp.112.1585886850044; Thu, 02 Apr 2020 21:07:30 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id v42sm4416221pgn.6.2020.04.02.21.07.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2020 21:07:29 -0700 (PDT) Subject: Re: [PATCH] watchdog: clarify that stop() is optional To: Bumsik Kim , wim@linux-watchdog.org, corbet@lwn.net Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Bumsik Kim References: <20200403031507.63487-1-k.bumsik@gmail.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <1fe9be6e-7da1-e738-c825-beddef31fd54@roeck-us.net> Date: Thu, 2 Apr 2020 21:07:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200403031507.63487-1-k.bumsik@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 4/2/20 8:15 PM, Bumsik Kim wrote: > The commit d0684c8a9354 ("watchdog: Make stop function optional") > made stop function not mandatory, but the comments > and the doc weren't reflected. Fix it to clarify. > > Signed-off-by: Bumsik Kim Reviewed-by: Guenter Roeck > --- > Documentation/watchdog/convert_drivers_to_kernel_api.rst | 2 +- > Documentation/watchdog/watchdog-kernel-api.rst | 2 +- > include/linux/watchdog.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/watchdog/convert_drivers_to_kernel_api.rst b/Documentation/watchdog/convert_drivers_to_kernel_api.rst > index dd934cc08e40..51b999b5551a 100644 > --- a/Documentation/watchdog/convert_drivers_to_kernel_api.rst > +++ b/Documentation/watchdog/convert_drivers_to_kernel_api.rst > @@ -115,7 +115,7 @@ Add the watchdog operations > --------------------------- > > All possible callbacks are defined in 'struct watchdog_ops'. You can find it > -explained in 'watchdog-kernel-api.txt' in this directory. start(), stop() and > +explained in 'watchdog-kernel-api.txt' in this directory. start() and > owner must be set, the rest are optional. You will easily find corresponding > functions in the old driver. Note that you will now get a pointer to the > watchdog_device as a parameter to these functions, so you probably have to > diff --git a/Documentation/watchdog/watchdog-kernel-api.rst b/Documentation/watchdog/watchdog-kernel-api.rst > index 864edbe932c1..068a55ee0d4a 100644 > --- a/Documentation/watchdog/watchdog-kernel-api.rst > +++ b/Documentation/watchdog/watchdog-kernel-api.rst > @@ -123,8 +123,8 @@ The list of watchdog operations is defined as:: > struct module *owner; > /* mandatory operations */ > int (*start)(struct watchdog_device *); > - int (*stop)(struct watchdog_device *); > /* optional operations */ > + int (*stop)(struct watchdog_device *); > int (*ping)(struct watchdog_device *); > unsigned int (*status)(struct watchdog_device *); > int (*set_timeout)(struct watchdog_device *, unsigned int); > diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h > index 417d9f37077a..1464ce6ffa31 100644 > --- a/include/linux/watchdog.h > +++ b/include/linux/watchdog.h > @@ -37,15 +37,15 @@ struct watchdog_governor; > * > * The watchdog_ops structure contains a list of low-level operations > * that control a watchdog device. It also contains the module that owns > - * these operations. The start and stop function are mandatory, all other > + * these operations. The start function is mandatory, all other > * functions are optional. > */ > struct watchdog_ops { > struct module *owner; > /* mandatory operations */ > int (*start)(struct watchdog_device *); > - int (*stop)(struct watchdog_device *); > /* optional operations */ > + int (*stop)(struct watchdog_device *); > int (*ping)(struct watchdog_device *); > unsigned int (*status)(struct watchdog_device *); > int (*set_timeout)(struct watchdog_device *, unsigned int); >