From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:35582 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbeJZPWD (ORCPT ); Fri, 26 Oct 2018 11:22:03 -0400 Received: by mail-wm1-f68.google.com with SMTP id w186-v6so321423wmf.0 for ; Thu, 25 Oct 2018 23:46:17 -0700 (PDT) Date: Fri, 26 Oct 2018 07:46:14 +0100 From: Lee Jones To: Rob Herring Cc: Pascal PAILLET-LME , Dmitry Torokhov , Mark Rutland , Liam Girdwood , Mark Brown , Wim Van Sebroeck , Guenter Roeck , linux-input@vger.kernel.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , LINUX-WATCHDOG , Benjamin Gaignard , Enric Balletbo i Serra Subject: Re: [PATCH v4 1/8] dt-bindings: mfd: document stpmic1 Message-ID: <20181026064614.GG4870@dell> References: <1539853324-29051-1-git-send-email-p.paillet@st.com> <1539853324-29051-2-git-send-email-p.paillet@st.com> <20181025094430.GQ4939@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, 25 Oct 2018, Rob Herring wrote: > On Thu, Oct 25, 2018 at 4:44 AM Lee Jones wrote: > > > > Rob: please grep your name for some feedback. [Moved to the top] > > I'm surprised Rob allowed you to add register bits in a DT property? > > Yeah, they are certainly questionable and not something we encourage, > but the alternative would be dozens of properties which only apply for > this one device and just get translated back to register values. I don't see how this device is any different to the 100's of devices which are already supported in DT. > > On Thu, 18 Oct 2018, Pascal PAILLET-LME wrote: > > > > > From: pascal paillet > > > > +Optional parent device properties: > > > +- st,main-control-register: > > > + -bit 1: Power cycling will be performed on turn OFF condition > > > + -bit 2: PWRCTRL is functional > > > + -bit 3: PWRCTRL active high > > > +- st,pads-pull-register: > > > + -bit 1: WAKEUP pull down is not active > > > + -bit 2: PWRCTRL pull up is active > > > + -bit 3: PWRCTRL pull down is active > > > + -bit 4: WAKEUP detector is disabled This should be part of the Pinctrl configuration/driver. And Pinctrl probably already has properties for this? > > > +- st,vin-control-register: > > > + -bit 0: VINLOW monitoring is enabled > > > + -bit [1...3]: VINLOW rising threshold > > > + 000 VINOK_f + 50mV > > > + 001 VINOK_f + 100mV > > > + 010 VINOK_f + 150mV > > > + 011 VINOK_f + 200mV > > > + 100 VINOK_f + 250mV > > > + 101 VINOK_f + 300mV > > > + 110 VINOK_f + 350mV > > > + 111 VINOK_f + 400mV > > > + -bit [4...5]: VINLOW hyst > > > + 00 100mV > > > + 01 200mV > > > + 10 300mV > > > + 11 400mV > > > + -bit 6: SW_OUT detector is disabled > > > + -bit 7: SW_IN detector is enabled. This should be part of the Regulator configuration/driver? > > > +- st,usb-control-register: > > > + -bit 3: SW_OUT current limit > > > + 0: 600mA > > > + 1: 1.1A > > > + -bit 4: VBUS_OTG discharge is enabled > > > + -bit 5: SW_OUT discharge is enabled > > > + -bit 6: VBUS_OTG detection is enabled > > > + -bit 7: BOOST_OVP is disabled This should be part of the USB configuration/driver? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog