Linux-Watchdog Archive on lore.kernel.org
 help / Atom feed
* [PATCH v2] watchdog: renesas_wdt: Fix typos
@ 2018-11-05 10:53 Fabrizio Castro
  2018-11-07 10:09 ` Simon Horman
  2018-12-03 13:38 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrizio Castro @ 2018-11-05 10:53 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck
  Cc: Fabrizio Castro, linux-watchdog, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

Do not use "," but ";" to separate instructions.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

---
v1->v2:
* Added changelog as suggested by Guenter Roeck

 drivers/watchdog/renesas_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index 0d74c3e..b570962 100644
--- a/drivers/watchdog/renesas_wdt.c
+++ b/drivers/watchdog/renesas_wdt.c
@@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
 		goto out_pm_disable;
 	}
 
-	priv->wdev.info = &rwdt_ident,
-	priv->wdev.ops = &rwdt_ops,
+	priv->wdev.info = &rwdt_ident;
+	priv->wdev.ops = &rwdt_ops;
 	priv->wdev.parent = &pdev->dev;
 	priv->wdev.min_timeout = 1;
 	priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] watchdog: renesas_wdt: Fix typos
  2018-11-05 10:53 [PATCH v2] watchdog: renesas_wdt: Fix typos Fabrizio Castro
@ 2018-11-07 10:09 ` Simon Horman
  2018-12-03 13:38 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2018-11-07 10:09 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Wim Van Sebroeck, Guenter Roeck, linux-watchdog,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

On Mon, Nov 05, 2018 at 10:53:47AM +0000, Fabrizio Castro wrote:
> Do not use "," but ";" to separate instructions.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> ---
> v1->v2:
> * Added changelog as suggested by Guenter Roeck

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> 
>  drivers/watchdog/renesas_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> index 0d74c3e..b570962 100644
> --- a/drivers/watchdog/renesas_wdt.c
> +++ b/drivers/watchdog/renesas_wdt.c
> @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
>  		goto out_pm_disable;
>  	}
>  
> -	priv->wdev.info = &rwdt_ident,
> -	priv->wdev.ops = &rwdt_ops,
> +	priv->wdev.info = &rwdt_ident;
> +	priv->wdev.ops = &rwdt_ops;
>  	priv->wdev.parent = &pdev->dev;
>  	priv->wdev.min_timeout = 1;
>  	priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] watchdog: renesas_wdt: Fix typos
  2018-11-05 10:53 [PATCH v2] watchdog: renesas_wdt: Fix typos Fabrizio Castro
  2018-11-07 10:09 ` Simon Horman
@ 2018-12-03 13:38 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2018-12-03 13:38 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Wim Van Sebroeck, Guenter Roeck, linux-watchdog, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

On Mon, Nov 05, 2018 at 10:53:47AM +0000, Fabrizio Castro wrote:
> Do not use "," but ";" to separate instructions.

This sentence would even be better as $subject, because current $subject
sounds like fixing a comment or so. Other than that:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 10:53 [PATCH v2] watchdog: renesas_wdt: Fix typos Fabrizio Castro
2018-11-07 10:09 ` Simon Horman
2018-12-03 13:38 ` Wolfram Sang

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable: git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org linux-watchdog@archiver.kernel.org
	public-inbox-index linux-watchdog


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/ public-inbox