From: Guenter Roeck <linux@roeck-us.net>
To: NeilBrown <neil@brown.name>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-watchdog@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix compilation problem for mt7621_wdt.c and rt2880_wdt.c
Date: Sun, 30 Dec 2018 09:16:47 -0800 [thread overview]
Message-ID: <20181230171647.GA8311@roeck-us.net> (raw)
In-Reply-To: <87va3baecv.fsf@notabene.neil.brown.name>
On Sun, Dec 30, 2018 at 02:21:52PM +1100, NeilBrown wrote:
>
> These files need
> #include <linux/mod_devicetable.h>
> to compile correctly.
>
> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
> Signed-off-by: NeilBrown <neil@brown.name>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mt7621_wdt.c | 1 +
> drivers/watchdog/rt2880_wdt.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
> index 5c4a764717c4..81208cd3f4ec 100644
> --- a/drivers/watchdog/mt7621_wdt.c
> +++ b/drivers/watchdog/mt7621_wdt.c
> @@ -17,6 +17,7 @@
> #include <linux/watchdog.h>
> #include <linux/moduleparam.h>
> #include <linux/platform_device.h>
> +#include <linux/mod_devicetable.h>
>
> #include <asm/mach-ralink/ralink_regs.h>
>
> diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
> index 98967f0a7d10..db7c57d82cfd 100644
> --- a/drivers/watchdog/rt2880_wdt.c
> +++ b/drivers/watchdog/rt2880_wdt.c
> @@ -18,6 +18,7 @@
> #include <linux/watchdog.h>
> #include <linux/moduleparam.h>
> #include <linux/platform_device.h>
> +#include <linux/mod_devicetable.h>
>
> #include <asm/mach-ralink/ralink_regs.h>
>
> --
> 2.14.0.rc0.dirty
>
prev parent reply other threads:[~2018-12-30 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 3:21 [PATCH] Fix compilation problem for mt7621_wdt.c and rt2880_wdt.c NeilBrown
2018-12-30 17:16 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181230171647.GA8311@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).