From: Guenter Roeck <linux@roeck-us.net>
To: YueHaibing <yuehaibing@huawei.com>
Cc: wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH -next] watchdog: pika_wdt: drop pointless static qualifier in pikawdt_init
Date: Wed, 23 Jan 2019 10:05:44 -0800 [thread overview]
Message-ID: <20190123180544.GC9781@roeck-us.net> (raw)
In-Reply-To: <20190123090524.13320-1-yuehaibing@huawei.com>
On Wed, Jan 23, 2019 at 05:05:24PM +0800, YueHaibing wrote:
> There is no need to have the 'post1' variable static since
> new value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Is anyone still using this driver ? If yes it might make sense to convert
it to use the watchdog subsystem.
Guenter
> ---
> drivers/watchdog/pika_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c
> index e0a6f8c..bb97f5b 100644
> --- a/drivers/watchdog/pika_wdt.c
> +++ b/drivers/watchdog/pika_wdt.c
> @@ -225,7 +225,7 @@ static int __init pikawdt_init(void)
> {
> struct device_node *np;
> void __iomem *fpga;
> - static u32 post1;
> + u32 post1;
> int ret;
>
> np = of_find_compatible_node(NULL, NULL, "pika,fpga");
> --
> 2.7.0
>
>
prev parent reply other threads:[~2019-01-23 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 9:05 [PATCH -next] watchdog: pika_wdt: drop pointless static qualifier in pikawdt_init YueHaibing
2019-01-23 18:05 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123180544.GC9781@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).