From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-watchdog@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 11/16] watchdog: renesas_wdt: drop warning after calling watchdog_init_timeout
Date: Fri, 19 Apr 2019 20:15:56 +0200
Message-ID: <20190419181601.7412-12-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20190419181601.7412-1-wsa+renesas@sang-engineering.com>
The core will print out details now.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/watchdog/renesas_wdt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index 8d1086b45c94..37d757288b22 100644
--- a/drivers/watchdog/renesas_wdt.c
+++ b/drivers/watchdog/renesas_wdt.c
@@ -236,9 +236,7 @@ static int rwdt_probe(struct platform_device *pdev)
watchdog_stop_on_unregister(&priv->wdev);
/* This overrides the default timeout only if DT configuration was found */
- ret = watchdog_init_timeout(&priv->wdev, 0, &pdev->dev);
- if (ret)
- dev_warn(&pdev->dev, "Specified timeout value invalid, using default\n");
+ watchdog_init_timeout(&priv->wdev, 0, &pdev->dev);
if (csra & RWTCSRA_TME) {
/* Ensure properly initialized dividers */
--
2.11.0
next prev parent reply index
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 18:15 [PATCH v3 00/16] watchdog: refactor init_timeout and update users Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 01/16] watchdog: refactor watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 02/16] watchdog: add error messages when initializing timeout fails Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 03/16] watchdog: cadence_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 04/16] watchdog: cadence_wdt: still probe if user supplied timeout is invalid Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 05/16] watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 06/16] watchdog: hpwdt: " Wolfram Sang
2019-04-19 21:18 ` Jerry Hoemann
2019-04-19 18:15 ` [PATCH v3 07/16] watchdog: i6300esb: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 08/16] watchdog: imx_sc_wdt: " Wolfram Sang
2019-04-29 10:15 ` Uwe Kleine-König
2019-04-29 12:37 ` Guenter Roeck
2019-04-29 13:19 ` Uwe Kleine-König
2019-04-19 18:15 ` [PATCH v3 09/16] watchdog: ni903x_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 10/16] watchdog: nic7018_wdt: " Wolfram Sang
2019-04-19 18:15 ` Wolfram Sang [this message]
2019-04-19 18:15 ` [PATCH v3 12/16] watchdog: sp5100_tco: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 13/16] watchdog: st_lpc_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 14/16] watchdog: stm32_iwdg: " Wolfram Sang
2019-04-19 18:16 ` [PATCH v3 15/16] watchdog: xen_wdt: " Wolfram Sang
2019-04-19 18:16 ` [PATCH v3 16/16] watchdog: ziirave_wdt: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419181601.7412-12-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Watchdog Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
linux-watchdog@vger.kernel.org
public-inbox-index linux-watchdog
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git