From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 796BBC43219 for ; Mon, 29 Apr 2019 13:19:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5011D2053B for ; Mon, 29 Apr 2019 13:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726403AbfD2NTS (ORCPT ); Mon, 29 Apr 2019 09:19:18 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41751 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbfD2NTR (ORCPT ); Mon, 29 Apr 2019 09:19:17 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hL6BZ-0008Nm-Kv; Mon, 29 Apr 2019 15:19:09 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hL6BX-0008Ne-87; Mon, 29 Apr 2019 15:19:07 +0200 Date: Mon, 29 Apr 2019 15:19:07 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Guenter Roeck Cc: Wolfram Sang , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Wim Van Sebroeck , Shawn Guo Subject: Re: [PATCH v3 08/16] watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout Message-ID: <20190429131907.xpl6duf4cvtwbmud@pengutronix.de> References: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> <20190419181601.7412-9-wsa+renesas@sang-engineering.com> <20190429101558.6vyiospb6oqsstt7@pengutronix.de> <616a9d4e-7050-a6c2-727d-f62e08d3d98c@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <616a9d4e-7050-a6c2-727d-f62e08d3d98c@roeck-us.net> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-watchdog@vger.kernel.org Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hello, On Mon, Apr 29, 2019 at 05:37:12AM -0700, Guenter Roeck wrote: > On 4/29/19 3:15 AM, Uwe Kleine-König wrote: > > On Fri, Apr 19, 2019 at 08:15:53PM +0200, Wolfram Sang wrote: > > > The core will print out details now. > > > > > > Reviewed-by: Guenter Roeck > > > Signed-off-by: Wolfram Sang > > > --- > > > drivers/watchdog/imx_sc_wdt.c | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > > diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c > > > index 86c2722f2a09..6dc24ceb1b2c 100644 > > > --- a/drivers/watchdog/imx_sc_wdt.c > > > +++ b/drivers/watchdog/imx_sc_wdt.c > > > > This driver isn't in next, and I don't know where to look for it. > > > > Branch watchdog-next of > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git Thanks, found it now. > > > @@ -117,10 +117,7 @@ static int imx_sc_wdt_probe(struct platform_device *pdev) > > > imx_sc_wdd->parent = &pdev->dev; > > > imx_sc_wdd->timeout = DEFAULT_TIMEOUT; > > > - ret = watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); > > > - if (ret) > > > - dev_warn(&pdev->dev, "Failed to set timeout value, using default\n"); > > > - > > > + watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); > > > > One side effect is however that ret isn't set any more. So I wonder if a > > failure in watchdog_init_timeout() really makes the core print the > > details as expected. > > > > Sorry, I don't understand. The warning is printed in watchdog_init_timeout(). > What does that have to do with setting ret here or not ? Ah, I thought the warning is done in the caller of the modified function. Maybe this means the commit log can be improved to for example: The function watchdog_init_timeout() itself already emits a more informative warning on failure. So drop the driver specific one. Otherwise my concerns are eliminated. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |