From: Wolfram Sang <wsa@the-dreams.de>
To: Nguyen An Hoan <na-hoan@jinso.co.jp>
Cc: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net, wsa+renesas@sang-engineering.com,
kuninori.morimoto.gx@renesas.com,
yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
cv-dong@jinso.co.jp
Subject: Re: [PATCH] watchdog: renesas_wdt: Fix interrupt enable for timer
Date: Thu, 23 May 2019 13:04:51 +0200 [thread overview]
Message-ID: <20190523110451.GA3979@kunai> (raw)
In-Reply-To: <1558603778-20848-1-git-send-email-na-hoan@jinso.co.jp>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
Hi,
On Thu, May 23, 2019 at 06:29:37PM +0900, Nguyen An Hoan wrote:
> From: Hoan Nguyen An <na-hoan@jinso.co.jp>
>
> Fix setting for bit WOVFE of RWTCSRA. Keep it enable follow hardware document.
Hmm, I can't find it in the docs. Which version of the documentation do
you use?
> - rwdt_write(priv, priv->cks, RWTCSRA);
> + val |= priv->cks;
> + rwdt_write(priv, val, RWTCSRA);
Have you tested this successfully? According to the docs, CKS bits are
all 1 by default. So, your |= operation should be a NOP and we can't
select a CKS value anymore if I am not mistaken.
> rwdt_write(priv, 0, RWTCSRB);
>
> while (readb_relaxed(priv->base + RWTCSRA) & RWTCSRA_WRFLG)
> cpu_relax();
> -
> - rwdt_write(priv, priv->cks | RWTCSRA_TME, RWTCSRA);
> + /* Enable interrupt and timer */
> + rwdt_write(priv, val | RWTCSRA_WOVFE | RWTCSRA_TME, RWTCSRA);
What is the use of enabling an interrupt without having an interrupt
handler? (And I never understood why there is an interrupt for an
overflowing watchdog. We won't have time to serve it, or am I
overlooking something obvious?)
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-23 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:29 [PATCH] watchdog: renesas_wdt: Fix interrupt enable for timer Nguyen An Hoan
2019-05-23 9:29 ` [PATCH] watchdog: renesas_wdt: Use 'dev' instead of dereferencing it repeatedly Nguyen An Hoan
2019-05-23 11:06 ` Wolfram Sang
2019-05-27 16:22 ` Guenter Roeck
2019-05-28 7:38 ` Geert Uytterhoeven
2019-06-07 17:31 ` Guenter Roeck
2019-06-13 9:28 ` Simon Horman
2019-05-23 11:04 ` Wolfram Sang [this message]
2019-05-23 11:26 ` [PATCH] watchdog: renesas_wdt: Fix interrupt enable for timer Geert Uytterhoeven
2019-05-24 1:13 ` "グェン・アン・ホァン"
2019-05-24 2:01 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523110451.GA3979@kunai \
--to=wsa@the-dreams.de \
--cc=cv-dong@jinso.co.jp \
--cc=geert+renesas@glider.be \
--cc=h-inayoshi@jinso.co.jp \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=na-hoan@jinso.co.jp \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).