From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Baruch Siach <baruch@tkos.co.il>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Patrice Chotard <patrice.chotard@st.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: digicolor_wdt: drop unused variable
Date: Wed, 10 Jul 2019 11:43:01 -0700 [thread overview]
Message-ID: <20190710184301.GA2961@roeck-us.net> (raw)
In-Reply-To: <20190710080904.317599-1-arnd@arndb.de>
On Wed, Jul 10, 2019 at 10:08:57AM +0200, Arnd Bergmann wrote:
> The last cleanup patch left behind an unused variable
> that should have been removed as well:
>
> drivers/watchdog/digicolor_wdt.c:121:6: error: unused variable 'ret' [-Werror,-Wunused-variable]
>
> Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Already submitted as https://patchwork.kernel.org/patch/11037487/ ...
Guenter
> ---
> drivers/watchdog/digicolor_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95bd238..073d37867f47 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dc_wdt *wdt;
> - int ret;
>
> wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
> if (!wdt)
> --
> 2.20.0
>
prev parent reply other threads:[~2019-07-10 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 8:08 [PATCH] watchdog: digicolor_wdt: drop unused variable Arnd Bergmann
2019-07-10 8:48 ` Baruch Siach
2019-07-10 18:43 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710184301.GA2961@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=michal.simek@xilinx.com \
--cc=patrice.chotard@st.com \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).