* [PATCH] watchdog: digicolor_wdt: drop unused variable
@ 2019-07-10 8:08 Arnd Bergmann
2019-07-10 8:48 ` Baruch Siach
2019-07-10 18:43 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-07-10 8:08 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Baruch Siach
Cc: Arnd Bergmann, Wolfram Sang, Patrice Chotard, Maxime Ripard,
Michal Simek, linux-watchdog, linux-arm-kernel, linux-kernel
The last cleanup patch left behind an unused variable
that should have been removed as well:
drivers/watchdog/digicolor_wdt.c:121:6: error: unused variable 'ret' [-Werror,-Wunused-variable]
Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/watchdog/digicolor_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
index 33cda95bd238..073d37867f47 100644
--- a/drivers/watchdog/digicolor_wdt.c
+++ b/drivers/watchdog/digicolor_wdt.c
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct dc_wdt *wdt;
- int ret;
wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
if (!wdt)
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] watchdog: digicolor_wdt: drop unused variable
2019-07-10 8:08 [PATCH] watchdog: digicolor_wdt: drop unused variable Arnd Bergmann
@ 2019-07-10 8:48 ` Baruch Siach
2019-07-10 18:43 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2019-07-10 8:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Wim Van Sebroeck, Guenter Roeck, Wolfram Sang, Patrice Chotard,
Maxime Ripard, Michal Simek, linux-watchdog, linux-arm-kernel,
linux-kernel
Hi Arnd,
On Wed, Jul 10, 2019 at 10:08:57AM +0200, Arnd Bergmann wrote:
> The last cleanup patch left behind an unused variable
> that should have been removed as well:
>
> drivers/watchdog/digicolor_wdt.c:121:6: error: unused variable 'ret' [-Werror,-Wunused-variable]
>
> Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> drivers/watchdog/digicolor_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95bd238..073d37867f47 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dc_wdt *wdt;
> - int ret;
>
> wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
> if (!wdt)
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] watchdog: digicolor_wdt: drop unused variable
2019-07-10 8:08 [PATCH] watchdog: digicolor_wdt: drop unused variable Arnd Bergmann
2019-07-10 8:48 ` Baruch Siach
@ 2019-07-10 18:43 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-07-10 18:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Wim Van Sebroeck, Baruch Siach, Wolfram Sang, Patrice Chotard,
Maxime Ripard, Michal Simek, linux-watchdog, linux-arm-kernel,
linux-kernel
On Wed, Jul 10, 2019 at 10:08:57AM +0200, Arnd Bergmann wrote:
> The last cleanup patch left behind an unused variable
> that should have been removed as well:
>
> drivers/watchdog/digicolor_wdt.c:121:6: error: unused variable 'ret' [-Werror,-Wunused-variable]
>
> Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Already submitted as https://patchwork.kernel.org/patch/11037487/ ...
Guenter
> ---
> drivers/watchdog/digicolor_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95bd238..073d37867f47 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dc_wdt *wdt;
> - int ret;
>
> wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
> if (!wdt)
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-10 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 8:08 [PATCH] watchdog: digicolor_wdt: drop unused variable Arnd Bergmann
2019-07-10 8:48 ` Baruch Siach
2019-07-10 18:43 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).