From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLACK,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05764C32751 for ; Wed, 31 Jul 2019 21:43:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC870208E4 for ; Wed, 31 Jul 2019 21:43:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mNtkPCUH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729479AbfGaVnQ (ORCPT ); Wed, 31 Jul 2019 17:43:16 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44910 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727600AbfGaVnQ (ORCPT ); Wed, 31 Jul 2019 17:43:16 -0400 Received: by mail-pg1-f195.google.com with SMTP id i18so32719902pgl.11; Wed, 31 Jul 2019 14:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2pcA+syml3U+BXTqn3loBbpI1NaVKecN6K6ot7Zdntg=; b=mNtkPCUHO21n40nc0/+DHmFweaSNsuJBE/xiqBmTMNLux8y9mlHBtE69fHb1010Q8V nEFAFkhiSXyqT8avuYi4chItgDtHAaV+D8XZFO99X2s5vVZqTcCkjqMKWQtMlPnp0q0n N/Fk4QITiuu9B3qQu0+iBTsW2e2Rs/4F1TJhQ0lYiemoB5St5rp/cp6qnoNVnK6Ii/XG iPzeV5M7wkPYxlBTfRbRYSY7Mf2+vyrA03C+FDROhpGIbw9MRUV68B4WerCd8XG9AJRE p9yiJzt5h55056+iVbJwTySoJ6ceb3KxcX9y23cN4Osv5G6zhgX+ZhT8wxJ2O3C0cjP/ ED7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=2pcA+syml3U+BXTqn3loBbpI1NaVKecN6K6ot7Zdntg=; b=W19+IN29emOqpVZCNDdFWaqO/2gKY4xQUdEKuXiAozWdssRGnC5e0pgWNYdAzgIipF Mreizy95IcYdyC2sI3N2FsDJgPrTm3VNE3iTYXEkKVguiaAFQlXdPZZooSwbl3QTyGfE 6xvMZUqvp88sKkHdPECgprbZCUuSvcN7HNv7PLEPJAjaW9lqks03X/WvT2p/PyKUfDoW hEMUxweTtQt+NQgJFQsii171rRvOCKMbedm5kmZLid3hod4BLAFaLGgYhJMlTt41hQib rqly7816LGmLhbQSknWC21M5hR9k1sfj+EGzqpWki5Uq0Jp57lCPRFsolWEepb5cghHM A4Ew== X-Gm-Message-State: APjAAAVLz1IyJPdjgw+tUAiTeTFheAx/FkCfjEGbFW5Bl9scsz2wDWNa Lccq+54F1auFFTlszO/R5hI= X-Google-Smtp-Source: APXvYqyZH5whmkutUHHOSPp06mIwUYsJ6Gy1C+Ms7szpgEJVfqIxdjSA2+KdpbKpaAP/4PdVCOrrZw== X-Received: by 2002:aa7:8e17:: with SMTP id c23mr49709377pfr.227.1564609395613; Wed, 31 Jul 2019 14:43:15 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id b36sm6576934pjc.16.2019.07.31.14.43.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2019 14:43:15 -0700 (PDT) Date: Wed, 31 Jul 2019 14:43:14 -0700 From: Guenter Roeck To: Andrey Smirnov Cc: linux-watchdog@vger.kernel.org, Chris Healy , Rick Ramstetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] watchdog: ziirave_wdt: Be more verbose during firmware update Message-ID: <20190731214314.GC17277@roeck-us.net> References: <20190731174252.18041-1-andrew.smirnov@gmail.com> <20190731174252.18041-4-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731174252.18041-4-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Jul 31, 2019 at 10:42:50AM -0700, Andrey Smirnov wrote: > Add more error logging to ziirave_firm_upload() for diagnostics. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Guenter Roeck > --- > drivers/watchdog/ziirave_wdt.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c > index 8c71341a9c1c..89ce6982ba53 100644 > --- a/drivers/watchdog/ziirave_wdt.c > +++ b/drivers/watchdog/ziirave_wdt.c > @@ -335,14 +335,18 @@ static int ziirave_firm_upload(struct watchdog_device *wdd, > > ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_JUMP_TO_BOOTLOADER, 1, > false); > - if (ret) > + if (ret) { > + dev_err(&client->dev, "Failed to jump to bootloader\n"); > return ret; > + } > > msleep(500); > > ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_DOWNLOAD_START, 1, true); > - if (ret) > + if (ret) { > + dev_err(&client->dev, "Failed to start download\n"); > return ret; > + } > > msleep(500); > > -- > 2.21.0 >