From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DC4C3A589 for ; Thu, 15 Aug 2019 18:12:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 559D82084D for ; Thu, 15 Aug 2019 18:12:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GWy0WOuF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731211AbfHOSMP (ORCPT ); Thu, 15 Aug 2019 14:12:15 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:39050 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730474AbfHOSMP (ORCPT ); Thu, 15 Aug 2019 14:12:15 -0400 Received: by mail-pg1-f196.google.com with SMTP id u17so1632290pgi.6; Thu, 15 Aug 2019 11:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n9tUkG7lD8HBZBIfJu4sHWhJeh6vg7iC3im3UhLYB78=; b=GWy0WOuF1yD+p7ShPnwB9tU5z2eta0obVE2c5a2C066QeGhwW48ZdMnzHSPRJKoe8d bajI7UKzxlBpoF/5H7WbgVtUpuoTr+6E1Zkeu6O5DGIWQ3aayNSDDpfarITDEJjAg4sN r/UHUb02gg9rKLcN6+pwFdQczJYFKX+6WBsarS0K4coff0Nybr9BIP63KN6gNZoCczuP SgPdZJthkEGEhRMVjEzM0s3XMVY8BGwkPJcDAvoxpxS2pkTpaLt77FKBNdc96dxqyeO8 DvftPVphIa6BfyA6TzUuEUDblNXBjE+ux4H/+yt7rJpN32Ti3s1V/V6m7wkS2DcNFLTb oL0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=n9tUkG7lD8HBZBIfJu4sHWhJeh6vg7iC3im3UhLYB78=; b=RVkv3sm1luQTagjKz5lv3OKIeDQzuvW2OGYfMWuLUZlGIM7tb+4CaHBvVJbat8ugMC sOOUe/vtmieUIFiSoNLGritXM0ofboCaeWhQhHmCmYOsQnTDHkOkz2+AJrKM/+3Ql9YT xgNDM8MBiPbk4BI4dv1UwPcJfhuucTiXHjq+MihRH6GMIsszUnr5kQDl2DWDtQEVv7G0 RInBCWQr7Qj4ttPK5oxFF2koAdiBBS8uooAdvGjc90OdxI/x0WH7su25xQy4Y3CTFVwe bFSIOen08F7ZjFevdLmM3aAoA5q8a7js95u5fajym98QnjnRQXH1Qq9Ls7yN3cxSXFAS TRNA== X-Gm-Message-State: APjAAAVK4zheUq/DDYF9Qcxu+r2wh9+NTVZwIE/Yc435lJNlfYFKBMzd bvQVga56bMIXQoh8YQYaie8= X-Google-Smtp-Source: APXvYqy3ZsrSdpCRks8cJhp/ftXr7OVvrV+UaVSt653H/GnIWE4REvYlquujbaMe2nfOmJKlPj9+tw== X-Received: by 2002:a62:7912:: with SMTP id u18mr7060592pfc.254.1565892735146; Thu, 15 Aug 2019 11:12:15 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j1sm2558476pgl.12.2019.08.15.11.12.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Aug 2019 11:12:14 -0700 (PDT) Date: Thu, 15 Aug 2019 11:12:13 -0700 From: Guenter Roeck To: Andrey Smirnov Cc: linux-watchdog@vger.kernel.org, Chris Healy , Rick Ramstetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/22] watchdog: ziirave_wdt: Don't bail out on unexpected timeout value Message-ID: <20190815181213.GA14388@roeck-us.net> References: <20190812200906.31344-1-andrew.smirnov@gmail.com> <20190812200906.31344-5-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812200906.31344-5-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Mon, Aug 12, 2019 at 01:08:48PM -0700, Andrey Smirnov wrote: > Reprogramming bootloader on watchdog MCU will result in reported > default timeout value of "0". That in turn will be unnecessarily > rejected by the driver as invalid device (-ENODEV). Simplify probe to > read stored timeout value, set it to a sane default if it is bogus, > and then program that value unconditionally. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Guenter Roeck