From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ABBEC3A589 for ; Thu, 15 Aug 2019 18:25:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F6BD2086C for ; Thu, 15 Aug 2019 18:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QvWGvwC3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730920AbfHOSZC (ORCPT ); Thu, 15 Aug 2019 14:25:02 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:34879 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbfHOSZC (ORCPT ); Thu, 15 Aug 2019 14:25:02 -0400 Received: by mail-pl1-f195.google.com with SMTP id gn20so1372730plb.2; Thu, 15 Aug 2019 11:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tUCC205/k2NpCbbKpNSZh2FstIsrHIBqKqoj8pLlYoA=; b=QvWGvwC3cbqBAYic+mI1BTsXf9DZBpB5/kgC4OGMFCum7D6mxuWBsC8GY5wOCbNhal WZnJ0D7QK+aOnKrT66Dnwc6FvQMqSdcYzcwR8RF+Vu5T9ECcMwc8JoweLG5oilzsOcWP EOf43zTcSZ/w/N87LDibeaPm7ELSWVG3DDqhD/QF+hvciPnXVmke0dPeX+P04olUG+fc hT6qgrcWhwb7hIwG8yI1+DF9Kly+8pEwg9Wf6adW1BahE7ZqTC44iDbMjP1TninEgN2I d5yMAusthF31XvvAZcNJISus5otYk/+OW8jsidZ3cST57g3zzMeHlN8I9rv93zgdzeHE FNyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=tUCC205/k2NpCbbKpNSZh2FstIsrHIBqKqoj8pLlYoA=; b=HRT0gSdo5ktJIB8ORyAKMKlfG204xeJ3F7IkYnz8991oZdFslWQ8hyRXeXorLlMQcB V3X3t/X4albkz0qpMZXqXiJL7VkVNdSuprGvwRLnQivOSb0Wqp8bvP8zjyUNmIpQAj+4 ilcNICMfuf+8QFK0fOrPjb/xH6V/V4sDkMPzwkYirvISVEAOpCHHR2ozJORLLAltnpkU UpFEmBDIxfUb283E3jPuqxCMeurkxUTe8i/EBka/XTIjjmHK8U10BqkTF0fTofEOKT+L /3hnkVTeCb8irqA3phkd5+/TQwnKdl6cztmT8RMbRy42iVI85jxdWop4h3arKsS+UoLH HCFg== X-Gm-Message-State: APjAAAU658hEDGUNjdEthWl1NELcbzV0YXjJVWfBfE8W1lH6a8OzT0qL kLEsuLuJXBbHVv6hhM+V0SE= X-Google-Smtp-Source: APXvYqwy2BIlYg6t8jYBljRC34feZ76UerOGmrtnRgV+nhbhHXPYa6nSiktIPKGq2KCTMaZU9WybBQ== X-Received: by 2002:a17:902:bc41:: with SMTP id t1mr5609218plz.171.1565893501983; Thu, 15 Aug 2019 11:25:01 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id f26sm4025706pfq.38.2019.08.15.11.25.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Aug 2019 11:25:01 -0700 (PDT) Date: Thu, 15 Aug 2019 11:25:00 -0700 From: Guenter Roeck To: Andrey Smirnov Cc: linux-watchdog@vger.kernel.org, Chris Healy , Rick Ramstetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 21/22] watchdog: ziirave_wdt: Drop ziirave_firm_write_block_data() Message-ID: <20190815182500.GQ14388@roeck-us.net> References: <20190812200906.31344-1-andrew.smirnov@gmail.com> <20190812200906.31344-22-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812200906.31344-22-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Archived-At: List-Archive: List-Post: On Mon, Aug 12, 2019 at 01:09:05PM -0700, Andrey Smirnov wrote: > There's only one user of ziirave_firm_write_block_data(), so we may as > well inline it. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Guenter Roeck