From: Maxime Ripard <mripard@kernel.org>
To: linux@roeck-us.net, wim@linux-watchdog.org
Cc: linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <mripard@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: [PATCH RESEND v2 3/6] dt-bindings: watchdog: sun4i: Add the watchdog interrupts
Date: Wed, 21 Aug 2019 16:38:32 +0200
Message-ID: <20190821143835.7294-3-mripard@kernel.org> (raw)
In-Reply-To: <20190821143835.7294-1-mripard@kernel.org>
From: Maxime Ripard <maxime.ripard@bootlin.com>
The Allwinner watchdog has an interrupt, either shared or dedicated
depending on the SoC, that has been described in some DT, but not all of
them.
The binding is also completely missing that description. Let's add that
property to be consistent.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
.../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
index dc7553f57708..31c95c404619 100644
--- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
@@ -31,9 +31,13 @@ properties:
reg:
maxItems: 1
+ interrupts:
+ maxItems: 1
+
required:
- compatible
- reg
+ - interrupts
unevaluatedProperties: false
@@ -42,6 +46,7 @@ examples:
wdt: watchdog@1c20c90 {
compatible = "allwinner,sun4i-a10-wdt";
reg = <0x01c20c90 0x10>;
+ interrupts = <24>;
timeout-sec = <10>;
};
--
2.21.0
next prev parent reply index
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:38 [PATCH RESEND v2 1/6] dt-bindings: watchdog: Add YAML schemas for the generic watchdog bindings Maxime Ripard
2019-08-21 14:38 ` [PATCH RESEND v2 2/6] dt-bindings: watchdog: Convert Allwinner watchdog to a schema Maxime Ripard
2019-08-30 16:48 ` Guenter Roeck
2019-08-21 14:38 ` Maxime Ripard [this message]
2019-08-30 16:48 ` [PATCH RESEND v2 3/6] dt-bindings: watchdog: sun4i: Add the watchdog interrupts Guenter Roeck
2019-08-21 14:38 ` [PATCH RESEND v2 4/6] dt-bindings: watchdog: sun4i: Add the watchdog clock Maxime Ripard
2019-08-30 16:48 ` Guenter Roeck
2019-08-21 14:38 ` [PATCH RESEND v2 5/6] ARM: dts: sunxi: Add missing watchdog interrupts Maxime Ripard
2019-08-21 14:38 ` [PATCH RESEND v2 6/6] ARM: dts: sunxi: Add missing watchdog clocks Maxime Ripard
2019-08-28 8:18 ` [PATCH RESEND v2 1/6] dt-bindings: watchdog: Add YAML schemas for the generic watchdog bindings Maxime Ripard
2019-08-30 16:48 ` Guenter Roeck
2019-09-02 11:46 ` Maxime Ripard
2019-09-03 0:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821143835.7294-3-mripard@kernel.org \
--to=mripard@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Watchdog Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
linux-watchdog@vger.kernel.org
public-inbox-index linux-watchdog
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git