From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Eugen.Hristev@microchip.com
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas.Ferre@microchip.com
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: sam9x60_wdt: add bindings
Date: Wed, 2 Oct 2019 11:56:51 +0200 [thread overview]
Message-ID: <20191002095627.GK4106@piout.net> (raw)
In-Reply-To: <1570001371-8174-1-git-send-email-eugen.hristev@microchip.com>
On 02/10/2019 07:35:23+0000, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Add bindings for Microchip SAM9X60 Watchdog Timer
>
> It has the same bindings as
> Documentation/devicetree/bindings/watchdog/atmel-sama5d4-wdt.txt
> except the compatible.
>
Maybe it can then use the same documentation file. However, I think you
should already use the yaml dt bindings schema instead of a simple text
file.
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> .../devicetree/bindings/watchdog/sam9x60-wdt.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/sam9x60-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/sam9x60-wdt.txt b/Documentation/devicetree/bindings/watchdog/sam9x60-wdt.txt
> new file mode 100644
> index 00000000..74b4e2d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/sam9x60-wdt.txt
> @@ -0,0 +1,34 @@
> +* Microchip SAM9X60 Watchdog Timer (WDT) Controller
> +
> +Required properties:
> +- compatible: "microchip,sam9x60-wdt"
> +- reg: base physical address and length of memory mapped region.
> +
> +Optional properties:
> +- timeout-sec: watchdog timeout value (in seconds).
> +- interrupts: interrupt number to the CPU.
> +- atmel,watchdog-type: should be "hardware" or "software".
> + "hardware": enable watchdog fault reset. A watchdog fault triggers
> + watchdog reset.
> + "software": enable watchdog fault interrupt. A watchdog fault asserts
> + watchdog interrupt.
> +- atmel,idle-halt: present if you want to stop the watchdog when the CPU is
> + in idle state.
> + CAUTION: This property should be used with care, it actually makes the
> + watchdog not counting when the CPU is in idle state, therefore the
> + watchdog reset time depends on mean CPU usage and will not reset at all
> + if the CPU stop working while it is in idle state, which is probably
> + not what you want.
> +- atmel,dbg-halt: present if you want to stop the watchdog when the CPU is
> + in debug state.
> +
> +Example:
> + watchdog@ffffff80 {
> + compatible = "microchip,sam9x60-wdt";
> + reg = <0xffffff80 0x24>;
> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 5>;
> + timeout-sec = <10>;
> + atmel,watchdog-type = "hardware";
> + atmel,dbg-halt;
> + atmel,idle-halt;
> + };
> --
> 2.7.4
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-10-02 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 7:35 [PATCH 1/3] dt-bindings: watchdog: sam9x60_wdt: add bindings Eugen.Hristev
2019-10-02 7:35 ` [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver Eugen.Hristev
2019-10-02 10:23 ` Alexandre Belloni
2019-10-02 11:07 ` Eugen.Hristev
2019-10-02 13:16 ` Guenter Roeck
2019-10-07 7:58 ` Eugen.Hristev
2019-10-07 12:36 ` Guenter Roeck
2019-10-07 13:14 ` Alexandre Belloni
2019-10-07 14:17 ` Eugen.Hristev
2019-10-02 13:38 ` kbuild test robot
2019-10-02 7:35 ` [PATCH 3/3] MAINTAINERS: add sam9x60_wdt Eugen.Hristev
2019-10-02 9:56 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002095627.GK4106@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).