From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4915CA9EB9 for ; Mon, 21 Oct 2019 08:33:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5DEB21721 for ; Mon, 21 Oct 2019 08:33:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbfJUIdE (ORCPT ); Mon, 21 Oct 2019 04:33:04 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58473 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfJUIdE (ORCPT ); Mon, 21 Oct 2019 04:33:04 -0400 X-Originating-IP: 86.207.98.53 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id CF33760017; Mon, 21 Oct 2019 08:33:01 +0000 (UTC) Date: Mon, 21 Oct 2019 10:33:01 +0200 From: Alexandre Belloni To: Martin =?iso-8859-1?Q?Hundeb=F8ll?= Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, Bruno Thomsen , linux-watchdog@vger.kernel.org Subject: Re: [PATCHv3] rtc: pcf2127: handle boot-enabled watchdog feature Message-ID: <20191021083301.GS3125@piout.net> References: <20191003133351.118538-1-martin@geanix.com> <20191021080838.2789-1-martin@geanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191021080838.2789-1-martin@geanix.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi, On 21/10/2019 10:08:38+0200, Martin Hundebøll wrote: > Linux should handle when the pcf2127 watchdog feature is enabled by the > bootloader. This is done by checking the watchdog timer value during > init, and set the WDOG_HW_RUNNING flag if the value differs from zero. > > Signed-off-by: Martin Hundebøll You could have kept Guenter's ack. > --- > > Change since v2: > * remove logging in case of error > > Change since v1: > * remove setting of WDOG_HW_RUNNING in pcf2127_wdt_start() > > drivers/rtc/rtc-pcf2127.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com