Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Laura Abbott <labbott@redhat.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
	Lennert Buytenhek <kernel@wantstofly.org>
Subject: Re: [PATCH] watchdog: Remove iop_wdt
Date: Wed, 20 Nov 2019 10:30:54 +0000
Message-ID: <20191120103054.GM25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAK8P3a2N+aDgFz75dFJy3Me9FPdyDSyPaa29FngLjfXX3MzfvA@mail.gmail.com>

On Wed, Nov 20, 2019 at 11:15:01AM +0100, Arnd Bergmann wrote:
> On Wed, Nov 20, 2019 at 11:03 AM Russell King - ARM Linux admin
> <linux@armlinux.org.uk> wrote:
> > On Tue, Nov 19, 2019 at 06:29:09AM -0800, Guenter Roeck wrote:
> > > On 11/19/19 1:40 AM, Arnd Bergmann wrote:
> > > > On Tue, Nov 19, 2019 at 3:08 AM Guenter Roeck <linux@roeck-us.net> wrote:
> > > > > On 11/18/19 2:04 PM, Laura Abbott wrote:
> > >
> > > Good point, especially since apparently no one cared for five years.
> >
> > Doesn't mean that there aren't interested parties.  I still have
> > IOP32x hardware running here in the form of a N2100 (my firewall)
> > and it seems that I never noticed this option disappearing until
> > now...
> 
> It's not that it was ever there for IOP32x: the driver was introduced in 2007
> and was available for IOP32x but failed to compile for it until 2014 when
> I sent the patch to disable the driver in all configurations that
> failed to build.

Well:

systems/n2100/boot/config-3.11.5+:CONFIG_IOP_WATCHDOG=m
systems/n2100/boot/config-3.12.6+:CONFIG_IOP_WATCHDOG=m
systems/n2100/boot/config-3.9.5+:CONFIG_IOP_WATCHDOG=m

-rw-rw-r-- 1 rmk rmk 5284 Dec 30  2013 systems/n2100/lib/modules/3.12.6+/kernel/drivers/watchdog/iop_wdt.ko
-rw-rw-r-- 1 rmk rmk 5276 Dec 20  2013 systems/n2100/lib/modules/3.9.5+/kernel/drivers/watchdog/iop_wdt.ko

It seems I've been carrying a patch to comment out the troublesome code:

-       write_wdtsr(IOP13XX_WDTCR_IB_RESET);
+//     write_wdtsr(IOP13XX_WDTCR_IB_RESET);

in my stable tree since 2015.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 22:04 Laura Abbott
2019-11-19  2:08 ` Guenter Roeck
2019-11-19  9:40   ` Arnd Bergmann
2019-11-19 14:29     ` Guenter Roeck
2019-11-20 10:03       ` Russell King - ARM Linux admin
2019-11-20 10:15         ` Arnd Bergmann
2019-11-20 10:30           ` Russell King - ARM Linux admin [this message]
2019-11-20 23:05             ` Guenter Roeck
2019-11-20 23:56               ` Russell King - ARM Linux admin
2019-11-21  0:36                 ` Guenter Roeck
2019-11-20  9:56     ` Lennert Buytenhek

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120103054.GM25745@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=arnd@arndb.de \
    --cc=kernel@wantstofly.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git