From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A311BC432C0 for ; Wed, 20 Nov 2019 10:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7986B2243E for ; Wed, 20 Nov 2019 10:31:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ViJfASR7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728689AbfKTKbF (ORCPT ); Wed, 20 Nov 2019 05:31:05 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:38284 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfKTKbE (ORCPT ); Wed, 20 Nov 2019 05:31:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LsRowSxwyb15GuNAkr+jjh5/r3yRoAAJmRPZPsLbvoY=; b=ViJfASR7OcAf6ixia3VgOPxIk hvySo1WkwlUuT27qm6nFMI6fzxSelUrGXMLjHSrID/GUTluLB3Tv0XPV/3fzgrJKN8rIuCe1GcAH6 Cg2SZj8e19kNJjYJ27/ZPyHG9KRZe5jzZZ8s3QRVSU+q73qIGKPzfPHraNdrnlbpp1KcgrLr9yhsV 3VFChq6lpJzdf3VMmqwpdZs0ec4ASXEBb8HHopHXid5lm/WxFbfSpCED6rYzQgmiF0KoNxUNcX9S8 S20+sPKHhNGl83HXAA47LEMcyFFA+UzqRFi108rKRpUmblZBY38P5sPdi2JvIuBypmDCwMNL9rvRO 0epohK0uQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:58714) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iXNGB-0007ii-AN; Wed, 20 Nov 2019 10:30:55 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iXNGA-0001eI-3c; Wed, 20 Nov 2019 10:30:54 +0000 Date: Wed, 20 Nov 2019 10:30:54 +0000 From: Russell King - ARM Linux admin To: Arnd Bergmann Cc: Guenter Roeck , Laura Abbott , Wim Van Sebroeck , "linux-kernel@vger.kernel.org" , LINUXWATCHDOG , Lennert Buytenhek Subject: Re: [PATCH] watchdog: Remove iop_wdt Message-ID: <20191120103054.GM25745@shell.armlinux.org.uk> References: <20191118220432.1611-1-labbott@redhat.com> <29e94219-22ca-c873-7209-64d1c357fe5c@roeck-us.net> <4f283ab6-0f3c-60e9-cfd1-29d10d978986@roeck-us.net> <20191120100341.GK25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Nov 20, 2019 at 11:15:01AM +0100, Arnd Bergmann wrote: > On Wed, Nov 20, 2019 at 11:03 AM Russell King - ARM Linux admin > wrote: > > On Tue, Nov 19, 2019 at 06:29:09AM -0800, Guenter Roeck wrote: > > > On 11/19/19 1:40 AM, Arnd Bergmann wrote: > > > > On Tue, Nov 19, 2019 at 3:08 AM Guenter Roeck wrote: > > > > > On 11/18/19 2:04 PM, Laura Abbott wrote: > > > > > > Good point, especially since apparently no one cared for five years. > > > > Doesn't mean that there aren't interested parties. I still have > > IOP32x hardware running here in the form of a N2100 (my firewall) > > and it seems that I never noticed this option disappearing until > > now... > > It's not that it was ever there for IOP32x: the driver was introduced in 2007 > and was available for IOP32x but failed to compile for it until 2014 when > I sent the patch to disable the driver in all configurations that > failed to build. Well: systems/n2100/boot/config-3.11.5+:CONFIG_IOP_WATCHDOG=m systems/n2100/boot/config-3.12.6+:CONFIG_IOP_WATCHDOG=m systems/n2100/boot/config-3.9.5+:CONFIG_IOP_WATCHDOG=m -rw-rw-r-- 1 rmk rmk 5284 Dec 30 2013 systems/n2100/lib/modules/3.12.6+/kernel/drivers/watchdog/iop_wdt.ko -rw-rw-r-- 1 rmk rmk 5276 Dec 20 2013 systems/n2100/lib/modules/3.9.5+/kernel/drivers/watchdog/iop_wdt.ko It seems I've been carrying a patch to comment out the troublesome code: - write_wdtsr(IOP13XX_WDTCR_IB_RESET); +// write_wdtsr(IOP13XX_WDTCR_IB_RESET); in my stable tree since 2015. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up