From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C73C33CB1 for ; Wed, 15 Jan 2020 07:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEA942467A for ; Wed, 15 Jan 2020 07:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726085AbgAOHUJ (ORCPT ); Wed, 15 Jan 2020 02:20:09 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:56957 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgAOHUJ (ORCPT ); Wed, 15 Jan 2020 02:20:09 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ircy8-0004ku-Qm; Wed, 15 Jan 2020 08:20:00 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ircy5-0007fK-Hu; Wed, 15 Jan 2020 08:19:57 +0100 Date: Wed, 15 Jan 2020 08:19:57 +0100 From: Marco Felsch To: Stefan Lengfeld Cc: support.opensource@diasemi.com, linux@roeck-us.net, Adam.Thomson.Opensource@diasemi.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] watchdog: da9062: make restart handler atomic safe Message-ID: <20200115071957.j7sptgbmuilgs2lj@pengutronix.de> References: <20200113091521.5754-1-m.felsch@pengutronix.de> <20200114200034.nbk6vf77ucngfs6o@porty> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200114200034.nbk6vf77ucngfs6o@porty> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:18:18 up 60 days, 22:36, 54 users, load average: 0.31, 0.13, 0.06 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-watchdog@vger.kernel.org Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi Stefan, On 20-01-14 21:00, Stefan Lengfeld wrote: > Hi Marco, > > On Mon, Jan 13, 2020 at 10:15:21AM +0100, Marco Felsch wrote: > > The restart handler is executed during the shutdown phase which is > > atomic/irq-less. The i2c framework supports atomic transfers since > > commit 63b96983a5dd ("i2c: core: introduce callbacks for atomic > > transfers") but unfortunately the regmap framework doesn't support it > > yet. Hard coding the i2c stuff can be done without worries since the > > DA9062 is an i2c-only device. > > > > Signed-off-by: Marco Felsch > > Reviewed-by: Stefan Lengfeld > > Thanks for picking up the patch and submitting it. I will send a v2 to cover Guenter's suggestion. Can I keep your reviewed by tag? Regards, Marco > Kind regards, > Stefan