Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ulrich Hecht <uli@fpond.eu>
Cc: linux-watchdog@vger.kernel.org, wsa@the-dreams.de
Subject: Re: Best practice when probe fails on armed watchdog?
Date: Wed, 29 Jan 2020 09:33:22 -0800
Message-ID: <20200129173322.GA7138@roeck-us.net> (raw)
In-Reply-To: <1731064051.261328.1580318179697@webmail.strato.com>

On Wed, Jan 29, 2020 at 06:16:19PM +0100, Ulrich Hecht wrote:
> Hi!
> 
> What is the right thing to do when a watchdog device that has been armed by the bootloader fails to probe? Should the driver
> 
> - disable the device and thus save the system from being torn down by a potentially malfunctioning watchdog, at the risk of missing issues further down the line, or
> - leave it as is (even though that would most likely result in a reset), hoping that the error is either transient or that there is a mechanism in place outside the kernel that will resolve it?
> 
> Is there a best practice for this case?
> 

I'd first ask _why_ the watchdog fails to probe. It may well be that
the hardware simply does not exist, or that the provided address points
to something else. Since that can happen, the driver should probably
not touch the HW at all if instantiating it fails. 

Guenter

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 17:16 Ulrich Hecht
2020-01-29 17:33 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129173322.GA7138@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=uli@fpond.eu \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git