Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* Best practice when probe fails on armed watchdog?
@ 2020-01-29 17:16 Ulrich Hecht
  2020-01-29 17:33 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Hecht @ 2020-01-29 17:16 UTC (permalink / raw)
  To: linux-watchdog; +Cc: wsa

Hi!

What is the right thing to do when a watchdog device that has been armed by the bootloader fails to probe? Should the driver

- disable the device and thus save the system from being torn down by a potentially malfunctioning watchdog, at the risk of missing issues further down the line, or
- leave it as is (even though that would most likely result in a reset), hoping that the error is either transient or that there is a mechanism in place outside the kernel that will resolve it?

Is there a best practice for this case?

CU
Uli

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Best practice when probe fails on armed watchdog?
  2020-01-29 17:16 Best practice when probe fails on armed watchdog? Ulrich Hecht
@ 2020-01-29 17:33 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-01-29 17:33 UTC (permalink / raw)
  To: Ulrich Hecht; +Cc: linux-watchdog, wsa

On Wed, Jan 29, 2020 at 06:16:19PM +0100, Ulrich Hecht wrote:
> Hi!
> 
> What is the right thing to do when a watchdog device that has been armed by the bootloader fails to probe? Should the driver
> 
> - disable the device and thus save the system from being torn down by a potentially malfunctioning watchdog, at the risk of missing issues further down the line, or
> - leave it as is (even though that would most likely result in a reset), hoping that the error is either transient or that there is a mechanism in place outside the kernel that will resolve it?
> 
> Is there a best practice for this case?
> 

I'd first ask _why_ the watchdog fails to probe. It may well be that
the hardware simply does not exist, or that the provided address points
to something else. Since that can happen, the driver should probably
not touch the HW at all if instantiating it fails. 

Guenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 17:16 Best practice when probe fails on armed watchdog? Ulrich Hecht
2020-01-29 17:33 ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git