Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error
@ 2020-02-03 16:10 Randy Dunlap
  2020-02-03 17:49 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-02-03 16:10 UTC (permalink / raw)
  To: LKML, linux-watchdog; +Cc: wim, Guenter Roeck, Matthias Brugger

From: Randy Dunlap <rdunlap@infradead.org>

Fix build error when CONFIG_RESET_CONTROLLER is not set by
selecting RESET_CONTROLLER.

ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe':
mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-watchdog@vger.kernel.org
---
 drivers/watchdog/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20200203.orig/drivers/watchdog/Kconfig
+++ linux-next-20200203/drivers/watchdog/Kconfig
@@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG
 	tristate "Mediatek SoCs watchdog support"
 	depends on ARCH_MEDIATEK || COMPILE_TEST
 	select WATCHDOG_CORE
+	select RESET_CONTROLLER
 	help
 	  Say Y here to include support for the watchdog timer
 	  in Mediatek SoCs.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error
  2020-02-03 16:10 [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error Randy Dunlap
@ 2020-02-03 17:49 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-02-03 17:49 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: LKML, linux-watchdog, wim, Matthias Brugger

On Mon, Feb 03, 2020 at 08:10:29AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build error when CONFIG_RESET_CONTROLLER is not set by
> selecting RESET_CONTROLLER.
> 
> ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe':
> mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-watchdog@vger.kernel.org

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20200203.orig/drivers/watchdog/Kconfig
> +++ linux-next-20200203/drivers/watchdog/Kconfig
> @@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG
>  	tristate "Mediatek SoCs watchdog support"
>  	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	select WATCHDOG_CORE
> +	select RESET_CONTROLLER
>  	help
>  	  Say Y here to include support for the watchdog timer
>  	  in Mediatek SoCs.
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 16:10 [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error Randy Dunlap
2020-02-03 17:49 ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git