From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FC1C35250 for ; Sat, 8 Feb 2020 14:01:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80EA121741 for ; Sat, 8 Feb 2020 14:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbgBHOBy (ORCPT ); Sat, 8 Feb 2020 09:01:54 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:44487 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727131AbgBHOBx (ORCPT ); Sat, 8 Feb 2020 09:01:53 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j0QgC-0002DY-CW; Sat, 08 Feb 2020 15:01:52 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j0QgC-0004Fa-33; Sat, 08 Feb 2020 15:01:52 +0100 Date: Sat, 8 Feb 2020 15:01:52 +0100 From: Marco Felsch To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Thomson , Stefan Lengfeld Subject: Re: [PATCH] watchdog: da9062: Add dependency on I2C Message-ID: <20200208140152.op4dplfvljosnlvb@pengutronix.de> References: <20200208130803.23387-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200208130803.23387-1-linux@roeck-us.net> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:00:11 up 85 days, 5:18, 88 users, load average: 0.00, 0.04, 0.00 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-watchdog@vger.kernel.org Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi, On 20-02-08 05:08, Guenter Roeck wrote: > Since commit 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic > safe"), the driver calls i2c functions directly. It now therefore depends > on I2C. This is a hard dependency which overrides COMPILE_TEST. I just wondered why it doesn't complain if no regmap support is on and surprise it provides stubs ^^ Is it worth to add i2c stubs too? Regards, Marco > Reported-by: kbuild test robot > Fixes: 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic safe") > Cc: Marco Felsch > Cc: Adam Thomson > Cc: Stefan Lengfeld > Signed-off-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index c3c8e0786a99..9ea2b43d4b01 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -207,6 +207,7 @@ config DA9063_WATCHDOG > config DA9062_WATCHDOG > tristate "Dialog DA9062/61 Watchdog" > depends on MFD_DA9062 || COMPILE_TEST > + depends on I2C > select WATCHDOG_CORE > help > Support for the watchdog in the DA9062 and DA9061 PMICs. > -- > 2.17.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |