From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96D56C2BA83 for ; Wed, 12 Feb 2020 11:05:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 798F12082F for ; Wed, 12 Feb 2020 11:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgBLLFt (ORCPT ); Wed, 12 Feb 2020 06:05:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:41300 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgBLLFt (ORCPT ); Wed, 12 Feb 2020 06:05:49 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 243ADAC6B; Wed, 12 Feb 2020 11:05:47 +0000 (UTC) Date: Wed, 12 Feb 2020 12:05:45 +0100 From: Jean Delvare To: Mika Westerberg Cc: "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Tom Abraham Subject: Re: wdat_wdt: access width inconsistency Message-ID: <20200212120545.56e8ec42@endymion> In-Reply-To: <20200212104747.GR2667@lahna.fi.intel.com> References: <20200210111638.64925c8e@endymion> <20200210112326.GP2667@lahna.fi.intel.com> <20200212113030.1c5c9524@endymion> <20200212104747.GR2667@lahna.fi.intel.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, 12 Feb 2020 12:47:47 +0200, Mika Westerberg wrote: > On Wed, Feb 12, 2020 at 11:30:30AM +0100, Jean Delvare wrote: > > (The underlying question being: can I get rid of that ALIGN() > > altogether while fixing the gas->access_width misuse bug?) > > I think the ALIGN() was there just because I did not realize that > access_width is 3 and not 4 for 32-bit memory. So it is not needed. > > I actually have a patch series that should fix this and the other issue > you found (I found a couple of spare cycles in the morning) so if you > don't mind I'll submit them soon. Sure please do, I don't care about ownership, I only want these bugs to be fixed. I got myself side-tracked by another issue at work this morning. I'll be happy to review your changes. -- Jean Delvare SUSE L3 Support