From: Guenter Roeck <email@example.com> To: Evan Benn <firstname.lastname@example.org> Cc: email@example.com, Julius Werner <firstname.lastname@example.org>, Rob Herring <email@example.com>, LKML <firstname.lastname@example.org>, email@example.com, "David S. Miller" <firstname.lastname@example.org>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Mauro Carvalho Chehab <email@example.com>, Wim Van Sebroeck <firstname.lastname@example.org>, Greg Kroah-Hartman <email@example.com>, Mark Rutland <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Date: Thu, 20 Feb 2020 07:43:11 -0800 Message-ID: <20200220154311.GA29658@roeck-us.net> (raw) In-Reply-To: <CAKz_xw2hvHL=a4s37dmuCTWDbxefQFR3rfcaNiWYJY4T+jqabA@mail.gmail.com> On Thu, Feb 20, 2020 at 05:41:09PM +1100, Evan Benn wrote: > Dear Xingyu, > > Could this driver also cover your usecase? I am not familiar with > meson, but it seems like the meson calls could > be replaced with arm_smccc calls. Then this driver will cover both > chips. I am not sure if your firmware is upstream > somewhere, but this might be adapted; > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405 > FWIW, the Meson driver has more functionality. Guenter > Thanks > > > On Thu, Feb 20, 2020 at 10:20 AM Guenter Roeck <firstname.lastname@example.org> wrote: > > > > On Wed, Feb 19, 2020 at 03:04:54PM -0800, Julius Werner wrote: > > > > You are not the first 'watchdog in firmware accessed via an SMC call'. > > > > Is there some more detail about what implementation this is? Part of > > > > TF-A? Defined by some spec (I can dream)? > > > > > > This is just some random implementation written by me because we > > > needed one. I would like it to be the new generic implementation, but > > > it sounds like people here prefer the naming to be MediaTek specific > > > (at least for now). The other SMC watchdog we're aware of is > > > imx_sc_wdt but unfortunately that seems to hardcode platform-specific > > > > There is one more pending, for Meson SMC. > > > > https://patchwork.kernel.org/project/linux-watchdog/list/?series=227733 > > > > Unfortunately it uses Meson firmware API functions, though it has pretty > > much the same functionality since those ultimately end up calling > > arm_smccc_smc(). > > > > Guenter > > > > > details in the interface (at least in the pretimeout SMC) so we can't > > > just expand that. With this driver I tried to directly wrap the kernel > > > watchdog interface so it should be platform-agnostic and possible to > > > expand this driver to other platforms later if desired. The SMC > > > function ID would still always have to be platform-specific, > > > unfortunately (but we could pass it in through the device tree), since > > > the Arm SMC spec doesn't really leave any room for OS-generic SMCs > > > like this.
next prev parent reply index Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-14 6:26 [PATCH 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn 2020-02-14 6:26 ` [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Evan Benn 2020-02-19 22:30 ` Rob Herring 2020-02-19 23:04 ` Julius Werner 2020-02-19 23:20 ` Guenter Roeck 2020-02-20 6:41 ` Evan Benn 2020-02-20 15:43 ` Guenter Roeck [this message] 2020-02-21 15:36 ` Xingyu Chen 2020-02-21 19:41 ` Julius Werner 2020-02-21 20:46 ` Guenter Roeck 2020-02-22 4:01 ` Xingyu Chen 2020-02-24 1:10 ` Evan Benn 2020-02-25 1:23 ` Julius Werner 2020-02-25 7:44 ` Xingyu Chen 2020-03-10 1:00 ` Evan Benn [not found] ` <email@example.com> 2020-03-11 19:24 ` Julius Werner 2020-03-13 16:13 ` Xingyu Chen 2020-02-14 6:26 ` [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn 2020-02-14 9:35 ` Enric Balletbo Serra 2020-02-14 14:10 ` Guenter Roeck 2020-02-14 21:32 ` Julius Werner 2020-02-15 1:39 ` Evan Benn 2020-02-20 6:50 ` Evan Benn 2020-02-20 15:52 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200220154311.GA29658@roeck-us.net \ --firstname.lastname@example.org \ --cc=Jonathan.Cameron@huawei.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Watchdog Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \ email@example.com public-inbox-index linux-watchdog Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog AGPL code for this site: git clone https://public-inbox.org/public-inbox.git