From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C444C10F25 for ; Fri, 6 Mar 2020 21:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B307206E6 for ; Fri, 6 Mar 2020 21:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726245AbgCFVPp (ORCPT ); Fri, 6 Mar 2020 16:15:45 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:8137 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgCFVPp (ORCPT ); Fri, 6 Mar 2020 16:15:45 -0500 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id BAEA6240006; Fri, 6 Mar 2020 21:15:38 +0000 (UTC) Date: Fri, 6 Mar 2020 22:15:38 +0100 From: Alexandre Belloni To: Dmitry Torokhov Cc: Anson Huang , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Alessandro Zummo , Zhang Rui , Daniel Lezcano , amit.kucheria@verdurent.com, wim@linux-watchdog.org, Guenter Roeck , Daniel Baluta , Oleksij Rempel , Greg Kroah-Hartman , Thomas Gleixner , Marco Felsch , Andy Shevchenko , Arnd Bergmann , Enric Balletbo i Serra , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Krzysztof Kozlowski , linux-arm-kernel , lkml , "linux-input@vger.kernel.org" , linux-rtc@vger.kernel.org, Linux PM , LINUXWATCHDOG , NXP Linux Team Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Message-ID: <20200306211538.GA8060@piout.net> References: <1583509356-8265-1-git-send-email-Anson.Huang@nxp.com> <1583509356-8265-3-git-send-email-Anson.Huang@nxp.com> <20200306193310.GI217608@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 06/03/2020 12:05:42-0800, Dmitry Torokhov wrote: > On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov > wrote: > > > > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote: > > > Add COMPILE_TEST support to i.MX SC keyboard driver for better compile > > > testing coverage. > > > > > > Signed-off-by: Anson Huang > > > > Applied, thank you. > > Actually, not: > > ERROR: "imx_scu_irq_register_notifier" > [drivers/input/keyboard/imx_sc_key.ko] undefined! > ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko] undefined! > ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko] undefined! > ERROR: "imx_scu_irq_unregister_notifier" > [drivers/input/keyboard/imx_sc_key.ko] undefined! > ERROR: "imx_scu_irq_group_enable" > [drivers/input/keyboard/imx_sc_key.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > make: *** [Makefile:1282: modules] Error 2 > > If you want to enable compile test coverage you need to provide stubs > for the above functions. > or select IMX_SCU or leave out COMPILE_TEST from the individual drivers as having COMPILE_TEST for IMX_SCU is enough to be able to select the drivers. > Thanks. > > -- > Dmitry -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com