From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0362EC3F2D6 for ; Sat, 7 Mar 2020 02:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5D012073B for ; Sat, 7 Mar 2020 02:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbgCGC51 (ORCPT ); Fri, 6 Mar 2020 21:57:27 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:46129 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbgCGC51 (ORCPT ); Fri, 6 Mar 2020 21:57:27 -0500 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id E1D1F200002; Sat, 7 Mar 2020 02:57:20 +0000 (UTC) Date: Sat, 7 Mar 2020 03:57:20 +0100 From: Alexandre Belloni To: Anson Huang Cc: Dmitry Torokhov , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Alessandro Zummo , Zhang Rui , Daniel Lezcano , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , Guenter Roeck , Daniel Baluta , Oleksij Rempel , Greg Kroah-Hartman , Thomas Gleixner , Marco Felsch , Andy Shevchenko , Arnd Bergmann , Enric Balletbo i Serra , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Krzysztof Kozlowski , linux-arm-kernel , lkml , "linux-input@vger.kernel.org" , "linux-rtc@vger.kernel.org" , Linux PM , LINUXWATCHDOG , dl-linux-imx Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Message-ID: <20200307025720.GA52231@piout.net> References: <1583509356-8265-1-git-send-email-Anson.Huang@nxp.com> <1583509356-8265-3-git-send-email-Anson.Huang@nxp.com> <20200306193310.GI217608@dtor-ws> <20200306211538.GA8060@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 07/03/2020 01:36:39+0000, Anson Huang wrote: > Hi, Alexandre > > > Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for > > KEYBOARD_IMX_SC_KEY > > > > On 06/03/2020 12:05:42-0800, Dmitry Torokhov wrote: > > > On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov > > > wrote: > > > > > > > > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote: > > > > > Add COMPILE_TEST support to i.MX SC keyboard driver for better > > > > > compile testing coverage. > > > > > > > > > > Signed-off-by: Anson Huang > > > > > > > > Applied, thank you. > > > > > > Actually, not: > > > > > > ERROR: "imx_scu_irq_register_notifier" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko] > > undefined! > > > ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko] > > undefined! > > > ERROR: "imx_scu_irq_unregister_notifier" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > ERROR: "imx_scu_irq_group_enable" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > > > make: *** [Makefile:1282: modules] Error 2 > > > > > > If you want to enable compile test coverage you need to provide stubs > > > for the above functions. > > > > > > > or select IMX_SCU > > > > or leave out COMPILE_TEST from the individual drivers as having > > COMPILE_TEST for IMX_SCU is enough to be able to select the drivers. > > Thanks, I already added the COMPILE_TEST for IMX_SCU which is in this same patch series, > without that IMX_SCU COMPILE_TEST patch, the build will failed, so in V2, I also added > the stubs into those IMX SCU APIs to make sure even IMX_SCU is NOT enabled, modules > with COMPILE_TEST can still pass build, please help review V2 patch set. > My point is that there is no need for the stubs. Simply have COMPILE_TEST for IMX_SCU as this is enough to extend coverage to all the drivers and significantly reduces the code size versus what you did in v2. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com