From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB451C54EEB for ; Mon, 27 Apr 2020 18:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C70F021973 for ; Mon, 27 Apr 2020 18:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588010743; bh=3sQzTpb+6EQHtl/5+DLUwh9oczyqWHopzdygG/nBKq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zq9JWY4Ab+CqACBR+cK4et0mCVESK7nPpmKc8xlUTVqXVKLStUfNOS/2gbJPWOWzj 9qvEha2prcdQOGQu/JV62GfryShwTynUKwK6mIhLLTcJ36lbKXHMtETJ/ZfPAVhRcE EzI4GcXphzw0om8UbPQDYRNOCaSye6ZI5Qq0TYew= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgD0SFn (ORCPT ); Mon, 27 Apr 2020 14:05:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:34636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbgD0SFm (ORCPT ); Mon, 27 Apr 2020 14:05:42 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6E20206D4; Mon, 27 Apr 2020 18:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588010742; bh=3sQzTpb+6EQHtl/5+DLUwh9oczyqWHopzdygG/nBKq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QD5I+wu7tUiwLoN/991mjtzmzF6o4uZAAk4sUawxC1Y5pkfnCS7en7gEsecvhWgat jaUVnplapxn0VjVZI6srYWtKrplFDpBi+duaXdXr/2i0/6VGfwKTTUTVyM8cdQK0Wt irZS8s/ZXa0sba+tRn2fRZHkkZHk4tDTGkliVrhs= Date: Mon, 27 Apr 2020 19:05:39 +0100 From: Mark Brown To: Michael Walle Cc: Thomas Gleixner , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Jason Cooper , Marc Zyngier , Greg Kroah-Hartman Subject: Re: [PATCH v3 06/16] irqchip: add sl28cpld interrupt controller support Message-ID: <20200427180539.GF4383@sirena.org.uk> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-7-michael@walle.cc> <87pnbtqhr1.fsf@nanos.tec.linutronix.de> <87f141bce0a4fda04b550647306be296@walle.cc> <20200427174427.GE4383@sirena.org.uk> <5d63026fc7c8700c2c7fb15267a9e441@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qftxBdZWiueWNAVY" Content-Disposition: inline In-Reply-To: <5d63026fc7c8700c2c7fb15267a9e441@walle.cc> X-Cookie: If your bread is stale, make toast. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org --qftxBdZWiueWNAVY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 27, 2020 at 08:01:14PM +0200, Michael Walle wrote: > Am 2020-04-27 19:44, schrieb Mark Brown: > > Looking at the changelog there the "we can't be sure" bit is that > > coccinelle couldn't follow the flags through from the caller to make > > sure that IRQF_ONESHOT is set so we're just oring it in unconditionally. > So it is correct that IRQF_ONESHOT is also set in the driver which is > using regmap_add_irq_chip(), right? It shouldn't break anything and my instinct is that it's better form. --qftxBdZWiueWNAVY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6nHvMACgkQJNaLcl1U h9ApOQf/S6MhJTO+bFChRr3cqXq9pRPnjvTfkt1e+TT+fIXOh2uMY8mRxXizy7En nNcSqd3id4MgeW/kEGX7lvy7/oekEZsIqZATQy0THN93fw1n/0t9u22LwLFW00/w MHfKqmnBMOv+o5aYUrJtsdspfhyS76FcRnaoe5gr6PPYtEbQnWRy4UV3HAPpp5mO 3d+MFa4olzoLwjD7HKkcIbbuWy3QcYgSn7HWfkqRPl+g06FIivX0SqC7kKLvTMzw ++5Oj+jFw8W3sfX0mcnF1U/PieOR5WYuy6PXUKcN4j2zy1XrEbfF3e9k/H6B710c UOuaJn2BH7J1F4zSNSNQlc4ihuaoPw== =Y8Z/ -----END PGP SIGNATURE----- --qftxBdZWiueWNAVY--