Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* watchdog: m54xx: Add missing include
@ 2020-05-08 19:41 Thomas Gleixner
  2020-05-08 19:54 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Gleixner @ 2020-05-08 19:41 UTC (permalink / raw)
  To: linux-watchdog; +Cc: Wim Van Sebroeck, Guenter Roeck

From: Thomas Gleixner <tglx@linutronix.de>
Date: Fri, 08 May 2020 21:26:58 +0200

A recent cleanup removed the mm.h include from uaccess_no.h in
m68k. This breaks the build of the m54xx watchdog driver:

  drivers/watchdog/m54xx_wdt.c:49:9: error: implicit declaration of function '__raw_readl'

Due to magic include chains the inclusion of mm.h in uaccess_no.h pulled in io.h.

Include 'linux/io.h' explicitely to fix this.

Fixes: 9e860351550b ("m68knommu: Remove mm.h include from uaccess_no.h")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org
---
 drivers/watchdog/m54xx_wdt.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/watchdog/m54xx_wdt.c
+++ b/drivers/watchdog/m54xx_wdt.c
@@ -29,6 +29,7 @@
 #include <linux/bitops.h>
 #include <linux/ioport.h>
 #include <linux/uaccess.h>
+#include <linux/io.h>
 
 #include <asm/coldfire.h>
 #include <asm/m54xxsim.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: watchdog: m54xx: Add missing include
  2020-05-08 19:41 watchdog: m54xx: Add missing include Thomas Gleixner
@ 2020-05-08 19:54 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-05-08 19:54 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-watchdog, Wim Van Sebroeck

On Fri, May 08, 2020 at 09:41:32PM +0200, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 08 May 2020 21:26:58 +0200
> 
> A recent cleanup removed the mm.h include from uaccess_no.h in
> m68k. This breaks the build of the m54xx watchdog driver:
> 
>   drivers/watchdog/m54xx_wdt.c:49:9: error: implicit declaration of function '__raw_readl'
> 
> Due to magic include chains the inclusion of mm.h in uaccess_no.h pulled in io.h.
> 
> Include 'linux/io.h' explicitely to fix this.
> 
> Fixes: 9e860351550b ("m68knommu: Remove mm.h include from uaccess_no.h")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/m54xx_wdt.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/watchdog/m54xx_wdt.c
> +++ b/drivers/watchdog/m54xx_wdt.c
> @@ -29,6 +29,7 @@
>  #include <linux/bitops.h>
>  #include <linux/ioport.h>
>  #include <linux/uaccess.h>
> +#include <linux/io.h>
>  
>  #include <asm/coldfire.h>
>  #include <asm/m54xxsim.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 19:41 watchdog: m54xx: Add missing include Thomas Gleixner
2020-05-08 19:54 ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git