From: Guenter Roeck <linux@roeck-us.net>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,
martin@geanix.com, bth@kamstrup.com
Subject: Re: [PATCH] rtc: pcf2127: watchdog: handle nowayout feature
Date: Thu, 4 Jun 2020 10:01:07 -0700 [thread overview]
Message-ID: <20200604170106.GA99753@roeck-us.net> (raw)
In-Reply-To: <20200604162602.76524-1-bruno.thomsen@gmail.com>
On Thu, Jun 04, 2020 at 06:26:02PM +0200, Bruno Thomsen wrote:
> Driver does not use module parameter for nowayout, so it need to
> statically initialize status variable of the watchdog_device based
> on CONFIG_WATCHDOG_NOWAYOUT.
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/rtc/rtc-pcf2127.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
> index 4e50d6768f13..0f7d0a9a2d18 100644
> --- a/drivers/rtc/rtc-pcf2127.c
> +++ b/drivers/rtc/rtc-pcf2127.c
> @@ -441,6 +441,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
> pcf2127->wdd.max_timeout = PCF2127_WD_VAL_MAX;
> pcf2127->wdd.timeout = PCF2127_WD_VAL_DEFAULT;
> pcf2127->wdd.min_hw_heartbeat_ms = 500;
> + pcf2127->wdd.status = WATCHDOG_NOWAYOUT_INIT_STATUS;
>
> watchdog_set_drvdata(&pcf2127->wdd, pcf2127);
>
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-06-04 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 16:26 [PATCH] rtc: pcf2127: watchdog: handle nowayout feature Bruno Thomsen
2020-06-04 17:01 ` Guenter Roeck [this message]
2020-06-05 22:35 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604170106.GA99753@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=martin@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).