From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A3CC433DF for ; Fri, 5 Jun 2020 14:09:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 597BE207F7 for ; Fri, 5 Jun 2020 14:09:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbgFEOJO (ORCPT ); Fri, 5 Jun 2020 10:09:14 -0400 Received: from mga11.intel.com ([192.55.52.93]:45252 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727813AbgFEOJO (ORCPT ); Fri, 5 Jun 2020 10:09:14 -0400 IronPort-SDR: 3GpFEgJh1E1/pkYsMX2LrazmJIRlAesPx29CBXWo3aDZQfDWDvly76YlZBbxYTbQt+cz9zChzU AG1/Ks9NdSeA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 07:09:14 -0700 IronPort-SDR: STm5cJBEx3cZwh5EDl1WI2zIniez547qsBBHLm0a+PZkJql6UaV6R0I9F6DqWusAPQO2MUnztk j822dzBvILJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,476,1583222400"; d="scan'208";a="471924635" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005.fm.intel.com with ESMTP; 05 Jun 2020 07:09:09 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jhD1z-00B2nb-Cy; Fri, 05 Jun 2020 17:09:11 +0300 Date: Fri, 5 Jun 2020 17:09:11 +0300 From: Andy Shevchenko To: Guenter Roeck Cc: Michael Walle , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm Mailing List , Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman Subject: Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog Message-ID: <20200605140911.GO2428291@smile.fi.intel.com> References: <20200604211039.12689-1-michael@walle.cc> <20200604211039.12689-5-michael@walle.cc> <8f042c2442852c29519c381833f3d289@walle.cc> <871a4990-5b94-3a17-01d4-74998375f08b@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871a4990-5b94-3a17-01d4-74998375f08b@roeck-us.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Fri, Jun 05, 2020 at 06:52:00AM -0700, Guenter Roeck wrote: > On 6/5/20 3:50 AM, Andy Shevchenko wrote: > > On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > >> Am 2020-06-05 10:14, schrieb Andy Shevchenko: > >>> On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: ... > >>>> +static bool nowayout = WATCHDOG_NOWAYOUT; > >>>> +module_param(nowayout, bool, 0); > >>>> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started > >>>> (default=" > >>>> + __MODULE_STRING(WATCHDOG_NOWAYOUT) > >>>> ")"); > >>>> + > >>>> +static int timeout; > >>>> +module_param(timeout, int, 0); > >>>> +MODULE_PARM_DESC(timeout, "Initial watchdog timeout in seconds"); > >>> > >>> Guenter ACKed this, but I'm wondering why we still need module > >>> parameters... > >> > >> How would a user change the nowayout or the timeout? For the latter > >> there is > >> a device tree entry, but thats not easy changable by the user. > > > > Yes, it's more question to VIm and Guenter than to you. > > > > Has support for providing module parameters with the kernel command line > been discontinued/deprecated, or did it run out of favor ? Sorry if I > missed that. Latter according to Greg KH. One of the (plenty) examples [1]. [1]: https://www.mail-archive.com/driverdev-devel@linuxdriverproject.org/msg96495.html > nowayout has a configuration default. A module parameter is sometimes > provided by drivers to be able to override it. The timeout provided > via devicetree or on the command line is only the initial/default > timeout, and the watchdog daemon can change it after opening the > watchdog device as it sees fit. Thanks for explanation. -- With Best Regards, Andy Shevchenko