From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5503CC433DF for ; Wed, 10 Jun 2020 07:19:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FC0C20734 for ; Wed, 10 Jun 2020 07:19:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y9ae5q6P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726266AbgFJHTv (ORCPT ); Wed, 10 Jun 2020 03:19:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726311AbgFJHTq (ORCPT ); Wed, 10 Jun 2020 03:19:46 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642DAC03E96B for ; Wed, 10 Jun 2020 00:19:45 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id h5so992428wrc.7 for ; Wed, 10 Jun 2020 00:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=11ciiGFTUr2GF55cgml5pBiTEF8081Q9X8UCb/QcHRA=; b=Y9ae5q6P3q0sJJ1zZgF5extf7FxIBPJDw9AERd1YPcixBQAP0Gr+TCXETNfkI0Ur3N B8mPHGrm319rRaMA4hgm+eI0R3VG+o6oRgiiCl8INYlYZnx1OnsY1uuUZyOnYb9PXFEf 5Mn3qxOZjRhNgI7R7zTJRQP4nS22KepHMy5J6lwf0eqyJYSEFoUgcuipvEYeo9d5tFgj uHcfLI/dm118AnKQJoCfnCkZm8DPVRTv3Mv35S+aFF9S/ifBiRJl6V58bk5CCgr3Na7f VB7ylHcVoSU5G6Cgq0d1kRMjbpWguWaBM4S6/TkoWS4gIyzZL6hewxemNDEwJJG0prKJ fzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=11ciiGFTUr2GF55cgml5pBiTEF8081Q9X8UCb/QcHRA=; b=Jwh96jWEzGSwV+oBKp2uJlLwdDmb6O+U8NCkp7grAabXLs7tf6GBl8B7QP7XCmYFMe 2iKcqckZvmU3eU41BL6ArR9Oj1cO2LqMmBjN7cwI6Se60842qUrpNqRkf0uvuGafBfBM Jv/Vwy+llAfe1hhaQuxvbxwu+w9FxgCdGqQ6DPuW7wFcRtjKiVLjCcTECI8W5oh9K2zp 4/ycXe6ztdZOuwBxrlPRIlYwNJ5y38BpNATUU/9XYdADtaJRwnKf60ovihkTBG9rvYiI BPyJ6+5pBIfduvHFGpfH6DchhKaMHp15juLPeIbC0sT0BARhc6B7/iRp7MKnJow9afEG RWmg== X-Gm-Message-State: AOAM53240/oW9Gp/2pL5p0ALQ8tXbxAjB3hMBGHCCc3wNFGda/tbFAGz H8+wecv1KTbqR4p/4VmQic9BCA== X-Google-Smtp-Source: ABdhPJx35j366zEzN8LJVnCpeR2FpiGqjvYG09aoVlwPYi548sT34jyAOpph5ZNw8v8eHkYZVutgRw== X-Received: by 2002:adf:e84c:: with SMTP id d12mr1957757wrn.284.1591773582952; Wed, 10 Jun 2020 00:19:42 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id 67sm7063666wrk.49.2020.06.10.00.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 00:19:42 -0700 (PDT) Date: Wed, 10 Jun 2020 08:19:40 +0100 From: Lee Jones To: Michael Walle Cc: Andy Shevchenko , Ranjani Sridharan , david.m.ertman@intel.com, shiraz.saleem@intel.com, Rob Herring , Mark Brown , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm Mailing List , Linus Walleij , Bartosz Golaszewski , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Greg Kroah-Hartman , Andy Shevchenko Subject: Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller Message-ID: <20200610071940.GS4106@dell> References: <7d7feb374cbf5a587dc1ce65fc3ad672@walle.cc> <20200608185651.GD4106@dell> <32231f26f7028d62aeda8fdb3364faf1@walle.cc> <20200609064735.GH4106@dell> <32287ac0488f7cbd5a7d1259c284e554@walle.cc> <20200609151941.GM4106@dell> <95e6ec9bbdf6af7a9ff9c31786f743f2@walle.cc> <20200609194505.GQ4106@dell> <3a6931248f0efcaf8efbb5425a9bd833@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3a6931248f0efcaf8efbb5425a9bd833@walle.cc> Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, 10 Jun 2020, Michael Walle wrote: > Am 2020-06-09 21:45, schrieb Lee Jones: > > On Tue, 09 Jun 2020, Michael Walle wrote: > > > > We do not need a 'simple-regmap' solution for your use-case. > > > > > > > > Since your device's registers are segregated, just split up the > > > > register map and allocate each sub-device with it's own slice. > > > > > > I don't get it, could you make a device tree example for my > > > use-case? (see also above) > > > > &i2cbus { > > mfd-device@10 { > > compatible = "simple-mfd"; > > reg = <10>; > > > > sub-device@10 { > > compatible = "vendor,sub-device"; > > reg = <10>; > > }; > > }; > > > > The Regmap config would be present in each of the child devices. > > > > Each child device would call devm_regmap_init_i2c() in .probe(). > > Ah, I see. If I'm not wrong, this still means to create an i2c > device driver with the name "simple-mfd". Yes, it does. > Besides that, I don't like this, because: > - Rob already expressed its concerns with "simple-mfd" and so on. Where did this take place? I'd like to read up on this. > - you need to duplicate the config in each sub device You can have a share a single config. > - which also means you are restricting the sub devices to be > i2c only (unless you implement and duplicate other regmap configs, > too). For this driver, SPI and MMIO may be viable options. You could also have a shared implementation to choose between different busses. > Thus, I'd rather implement a simple-mfd.c which implement a common > I2C driver for now and populate its children using > devm_of_platform_populate(). This could be extended to support other > type of regmaps like SPI in the future. > > Also some MFD drivers could be moved to this, a likely candidate is > the smsc-ece1099.c. Although I don't really understand its purpose, > if don't have CONFIG_OF. > > Judging from the existing code, this simple-mfd.c wouldn't just be > "a list of compatible" strings but also additional quirks and tweaks > for particular devices in this list. Hold off on the simple-mfd.c idea, as I'm not taken by it yet and wouldn't want you to waste your time. I have another idea which would help. Give me a few days to put something together. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog