Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* [RESEND PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML
@ 2020-06-25 19:29 Sai Prakash Ranjan
  2020-06-25 19:29 ` [RESEND PATCHv3 1/2] dt-bindings: watchdog: " Sai Prakash Ranjan
  2020-06-25 19:29 ` [RESEND PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
  0 siblings, 2 replies; 5+ messages in thread
From: Sai Prakash Ranjan @ 2020-06-25 19:29 UTC (permalink / raw)
  To: Guenter Roeck, linux-watchdog, Wim Van Sebroeck
  Cc: Douglas Anderson, Bjorn Andersson, Stephen Boyd, linux-kernel,
	linux-arm-kernel, linux-arm-msm, Rob Herring, devicetree,
	Sai Prakash Ranjan

This series converts QCOM watchdog timer bindings to YAML. Also
it adds the missing SoC-specific compatible for QCS404, SC7180,
SDM845 and SM8150 SoCs.

v1: https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ranjan@codeaurora.org/
v2: https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/

Resending this series with watchdog mailing list added.

Changes since v2:
 * Add missing compatibles to enum.

Changes since v1:
 As per Rob's suggestion:
  * Replaced oneOf+const with enum.
  * Removed timeout-sec and included watchdog.yaml.
  * Removed repeated use of const:qcom,kpss-wdt and made use of enum.

Sai Prakash Ranjan (2):
  dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
  dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
    SM8150

 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [RESEND PATCHv3 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
  2020-06-25 19:29 [RESEND PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
@ 2020-06-25 19:29 ` Sai Prakash Ranjan
  2020-06-30 20:37   ` Guenter Roeck
  2020-06-25 19:29 ` [RESEND PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
  1 sibling, 1 reply; 5+ messages in thread
From: Sai Prakash Ranjan @ 2020-06-25 19:29 UTC (permalink / raw)
  To: Guenter Roeck, linux-watchdog, Wim Van Sebroeck
  Cc: Douglas Anderson, Bjorn Andersson, Stephen Boyd, linux-kernel,
	linux-arm-kernel, linux-arm-msm, Rob Herring, devicetree,
	Sai Prakash Ranjan, Rob Herring

Convert QCOM watchdog timer bindings to DT schema format using
json-schema.

Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ------------
 .../bindings/watchdog/qcom-wdt.yaml           | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
deleted file mode 100644
index 41aeaa2ff0f8..000000000000
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Qualcomm Krait Processor Sub-system (KPSS) Watchdog
----------------------------------------------------
-
-Required properties :
-- compatible : shall contain only one of the following:
-
-			"qcom,kpss-wdt-msm8960"
-			"qcom,kpss-wdt-apq8064"
-			"qcom,kpss-wdt-ipq8064"
-			"qcom,kpss-wdt-ipq4019"
-			"qcom,kpss-timer"
-			"qcom,scss-timer"
-			"qcom,kpss-wdt"
-
-- reg : shall contain base register location and length
-- clocks : shall contain the input clock
-
-Optional properties :
-- timeout-sec : shall contain the default watchdog timeout in seconds,
-                if unset, the default timeout is 30 seconds
-
-Example:
-	watchdog@208a038 {
-		compatible = "qcom,kpss-wdt-ipq8064";
-		reg = <0x0208a038 0x40>;
-		clocks = <&sleep_clk>;
-		timeout-sec = <10>;
-	};
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
new file mode 100644
index 000000000000..5448cc537a03
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
+
+maintainers:
+  - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    enum:
+      - qcom,kpss-timer
+      - qcom,kpss-wdt
+      - qcom,kpss-wdt-apq8064
+      - qcom,kpss-wdt-ipq4019
+      - qcom,kpss-wdt-ipq8064
+      - qcom,kpss-wdt-msm8960
+      - qcom,scss-timer
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+examples:
+  - |
+    watchdog@208a038 {
+      compatible = "qcom,kpss-wdt-ipq8064";
+      reg = <0x0208a038 0x40>;
+      clocks = <&sleep_clk>;
+      timeout-sec = <10>;
+    };
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [RESEND PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150
  2020-06-25 19:29 [RESEND PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
  2020-06-25 19:29 ` [RESEND PATCHv3 1/2] dt-bindings: watchdog: " Sai Prakash Ranjan
@ 2020-06-25 19:29 ` Sai Prakash Ranjan
  2020-06-30 20:39   ` Guenter Roeck
  1 sibling, 1 reply; 5+ messages in thread
From: Sai Prakash Ranjan @ 2020-06-25 19:29 UTC (permalink / raw)
  To: Guenter Roeck, linux-watchdog, Wim Van Sebroeck
  Cc: Douglas Anderson, Bjorn Andersson, Stephen Boyd, linux-kernel,
	linux-arm-kernel, linux-arm-msm, Rob Herring, devicetree,
	Sai Prakash Ranjan, Rob Herring

Add missing compatible for watchdog timer on QCS404,
SC7180, SDM845 and SM8150 SoCs.

Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 5448cc537a03..0709ddf0b6a5 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -15,6 +15,10 @@ allOf:
 properties:
   compatible:
     enum:
+      - qcom,apss-wdt-qcs404
+      - qcom,apss-wdt-sc7180
+      - qcom,apss-wdt-sdm845
+      - qcom,apss-wdt-sm8150
       - qcom,kpss-timer
       - qcom,kpss-wdt
       - qcom,kpss-wdt-apq8064
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RESEND PATCHv3 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
  2020-06-25 19:29 ` [RESEND PATCHv3 1/2] dt-bindings: watchdog: " Sai Prakash Ranjan
@ 2020-06-30 20:37   ` Guenter Roeck
  0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2020-06-30 20:37 UTC (permalink / raw)
  To: Sai Prakash Ranjan
  Cc: linux-watchdog, Wim Van Sebroeck, Douglas Anderson,
	Bjorn Andersson, Stephen Boyd, linux-kernel, linux-arm-kernel,
	linux-arm-msm, Rob Herring, devicetree, Rob Herring

On Fri, Jun 26, 2020 at 12:59:04AM +0530, Sai Prakash Ranjan wrote:
> Convert QCOM watchdog timer bindings to DT schema format using
> json-schema.
> 
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ------------
>  .../bindings/watchdog/qcom-wdt.yaml           | 44 +++++++++++++++++++
>  2 files changed, 44 insertions(+), 28 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>  create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> deleted file mode 100644
> index 41aeaa2ff0f8..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Qualcomm Krait Processor Sub-system (KPSS) Watchdog
> ----------------------------------------------------
> -
> -Required properties :
> -- compatible : shall contain only one of the following:
> -
> -			"qcom,kpss-wdt-msm8960"
> -			"qcom,kpss-wdt-apq8064"
> -			"qcom,kpss-wdt-ipq8064"
> -			"qcom,kpss-wdt-ipq4019"
> -			"qcom,kpss-timer"
> -			"qcom,scss-timer"
> -			"qcom,kpss-wdt"
> -
> -- reg : shall contain base register location and length
> -- clocks : shall contain the input clock
> -
> -Optional properties :
> -- timeout-sec : shall contain the default watchdog timeout in seconds,
> -                if unset, the default timeout is 30 seconds
> -
> -Example:
> -	watchdog@208a038 {
> -		compatible = "qcom,kpss-wdt-ipq8064";
> -		reg = <0x0208a038 0x40>;
> -		clocks = <&sleep_clk>;
> -		timeout-sec = <10>;
> -	};
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> new file mode 100644
> index 000000000000..5448cc537a03
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
> +
> +maintainers:
> +  - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,kpss-timer
> +      - qcom,kpss-wdt
> +      - qcom,kpss-wdt-apq8064
> +      - qcom,kpss-wdt-ipq4019
> +      - qcom,kpss-wdt-ipq8064
> +      - qcom,kpss-wdt-msm8960
> +      - qcom,scss-timer
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +examples:
> +  - |
> +    watchdog@208a038 {
> +      compatible = "qcom,kpss-wdt-ipq8064";
> +      reg = <0x0208a038 0x40>;
> +      clocks = <&sleep_clk>;
> +      timeout-sec = <10>;
> +    };

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RESEND PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150
  2020-06-25 19:29 ` [RESEND PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
@ 2020-06-30 20:39   ` Guenter Roeck
  0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2020-06-30 20:39 UTC (permalink / raw)
  To: Sai Prakash Ranjan
  Cc: linux-watchdog, Wim Van Sebroeck, Douglas Anderson,
	Bjorn Andersson, Stephen Boyd, linux-kernel, linux-arm-kernel,
	linux-arm-msm, Rob Herring, devicetree, Rob Herring

On Fri, Jun 26, 2020 at 12:59:05AM +0530, Sai Prakash Ranjan wrote:
> Add missing compatible for watchdog timer on QCS404,
> SC7180, SDM845 and SM8150 SoCs.
> 
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 5448cc537a03..0709ddf0b6a5 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -15,6 +15,10 @@ allOf:
>  properties:
>    compatible:
>      enum:
> +      - qcom,apss-wdt-qcs404
> +      - qcom,apss-wdt-sc7180
> +      - qcom,apss-wdt-sdm845
> +      - qcom,apss-wdt-sm8150
>        - qcom,kpss-timer
>        - qcom,kpss-wdt
>        - qcom,kpss-wdt-apq8064

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 19:29 [RESEND PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
2020-06-25 19:29 ` [RESEND PATCHv3 1/2] dt-bindings: watchdog: " Sai Prakash Ranjan
2020-06-30 20:37   ` Guenter Roeck
2020-06-25 19:29 ` [RESEND PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
2020-06-30 20:39   ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git