* [PATCH][next] watchdog: scx200_wdt: Use fallthrough pseudo-keyword
@ 2020-07-17 16:40 Gustavo A. R. Silva
2020-07-17 19:33 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-17 16:40 UTC (permalink / raw)
To: Jim Cromie, Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1] https://www.kernel.org/doc/html/v5.7-rc7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/watchdog/scx200_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/scx200_wdt.c b/drivers/watchdog/scx200_wdt.c
index c94098acb78f..7b5e18323f3f 100644
--- a/drivers/watchdog/scx200_wdt.c
+++ b/drivers/watchdog/scx200_wdt.c
@@ -186,7 +186,7 @@ static long scx200_wdt_ioctl(struct file *file, unsigned int cmd,
margin = new_margin;
scx200_wdt_update_margin();
scx200_wdt_ping();
- /* Fall through */
+ fallthrough;
case WDIOC_GETTIMEOUT:
if (put_user(margin, p))
return -EFAULT;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] watchdog: scx200_wdt: Use fallthrough pseudo-keyword
2020-07-17 16:40 [PATCH][next] watchdog: scx200_wdt: Use fallthrough pseudo-keyword Gustavo A. R. Silva
@ 2020-07-17 19:33 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-07-17 19:33 UTC (permalink / raw)
To: Gustavo A. R. Silva, Jim Cromie, Wim Van Sebroeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva
On 7/17/20 9:40 AM, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/v5.7-rc7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/scx200_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/scx200_wdt.c b/drivers/watchdog/scx200_wdt.c
> index c94098acb78f..7b5e18323f3f 100644
> --- a/drivers/watchdog/scx200_wdt.c
> +++ b/drivers/watchdog/scx200_wdt.c
> @@ -186,7 +186,7 @@ static long scx200_wdt_ioctl(struct file *file, unsigned int cmd,
> margin = new_margin;
> scx200_wdt_update_margin();
> scx200_wdt_ping();
> - /* Fall through */
> + fallthrough;
> case WDIOC_GETTIMEOUT:
> if (put_user(margin, p))
> return -EFAULT;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-17 19:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 16:40 [PATCH][next] watchdog: scx200_wdt: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-17 19:33 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).