From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 889F2C433DF for ; Wed, 29 Jul 2020 19:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 632672075F for ; Wed, 29 Jul 2020 19:08:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596049739; bh=rbpV2qp3er29+JB9rip/TW1FjAAjVqLcfYeXHXwZePU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PU8cWnfq0du56LJDXWN0YI/P1B94bJTTDyFazh3ZGJLfjTIqwoWK5xZwf4lsiN/Ob ztccgMAtconJeW2zBCr2bZKPE7V210AgrNOSO7T74pCBWx7GNFSAfcWRqTrjCmWG9Z lYtNB2wAoX0/KL60Jo+NONKCpi5p9Fe2el2cfFII= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726476AbgG2TI7 convert rfc822-to-8bit (ORCPT ); Wed, 29 Jul 2020 15:08:59 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:38955 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgG2TI6 (ORCPT ); Wed, 29 Jul 2020 15:08:58 -0400 Received: by mail-ej1-f67.google.com with SMTP id f24so4972711ejx.6; Wed, 29 Jul 2020 12:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Kk6GZ/lJmAXVSU51HkWJo7PA9w7q1gYfnsyVr0WMPOk=; b=JLMz2iC/vIPVcWWEm4JrUKpTuusef8Vp/EgxzHIqjTRyD4XJ3GUnlMaun8M/Jq/Peo YsR5JQ9XKUHfb4lZwLrt2aFCgWs+iwZGyxTJgIfqaAsCRie/kLQ6/8r+foY0mG+ezcLD zVgT5fO5KoHXE0XpkqzTUI5YB39q69Kl3McHzaMbCJhpTYlH9eQ29nSt0CUxb0Xa93NI Upa+TZivwyME//onZqU9B4Tfv69Rs7ha5FiFK77w0nG4utKXX2oJLZbQA+C3sA7TP/jx HVyCAEM6yXlOZXsrL9UDt27rHAE4CW5yMSpLcVPkpejpexhHYMfAhuYPDZQqUqESpnPl /ikg== X-Gm-Message-State: AOAM533P9pkJ+1eDzMCIzKbOUX0WgS3tNOpRjVs4eDAu7wajH9dBS+Vt 3kGYKAP2ttdGI2/XcgZvGrA= X-Google-Smtp-Source: ABdhPJy+cd4Zv9RClGXMrb12WPzglxJiIigi0VSAL6EF6L9FGlqR/jQZQ2fHi+OZEEkZV03WOmvLzQ== X-Received: by 2002:a17:906:6d4d:: with SMTP id a13mr31002287ejt.146.1596049736098; Wed, 29 Jul 2020 12:08:56 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id m5sm2616809edr.59.2020.07.29.12.08.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Jul 2020 12:08:55 -0700 (PDT) Date: Wed, 29 Jul 2020 21:08:52 +0200 From: Krzysztof Kozlowski To: Tomasz Figa Cc: Guenter Roeck , Russell King , Kukjin Kim , Vincent Sanders , Simtec Linux Team , Kyungmin Park , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Arnd Bergmann , Linus Walleij , linux-kernel , linux-arm-kernel , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, "open list:COMMON CLK FRAMEWORK" , linux-watchdog@vger.kernel.org, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Subject: Re: [PATCH 5/7] ARM: samsung: Kill useless HAVE_S3C2410_WATCHDOG Message-ID: <20200729190852.GA5822@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-6-krzk@kernel.org> <20200729170245.GA177035@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Jul 29, 2020 at 07:36:38PM +0200, Tomasz Figa wrote: > 2020年7月29日(水) 19:02 Guenter Roeck : > > > > On Wed, Jul 29, 2020 at 06:09:40PM +0200, Krzysztof Kozlowski wrote: > > > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs does > > > not have sense, because: > > > 1. All ARMv7 and ARMv8 Samsung SoCs have watchdog, > > > 2. All architecture Kconfigs were selecting it (if WATCHDOG framework is > > > chosen), > > > 3. HAVE_S3C2410_WATCHDOG is doing nothing except being a dependency of > > > actual Samsung SoC watchdog driver, which is enabled manually by > > > specific defconfigs. > > > > > > HAVE_S3C2410_WATCHDOG can be safely removed. > > > > > > > That is not really correct. HAVE_S3C2410_WATCHDOG is used to ensure > > that users can only enable S3C2410_WATCHDOG if the watchdog actually > > exists in a system. With this change, it can be enabled for all > > architectures and platforms. > > > > NACK. > > > > Guenter > > > > I'd side with Guenter on this. We better not flood users' screens with > options that are not relevant to their hardware. > > An alternative here could be making CONFIG_S3C2410_WATCHDOG depend on > a general symbol for Samsung SoC support if there is such, but then, > are we 100% sure that all the Samsung SoCs would actually have exactly > this watchdog? If a new one shows up, one would have to bring back > this HAVE_S3C2410_WATCHDOG symbol. Ah, good points. Indeed for all of such SoC drivers we usually just depend on architecture to limit the choices on other architectures. In this case it would be: depends on ARCH_EXYNOS || ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210 || COMPILE_TEST I admit it is pretty long, but we already use this pattern. In shorter version (less ARCH*) for all drivers, in full version also in: drivers/iio/adc/Kconfig drivers/gpu/drm/exynos/Kconfig Have in mind that in general we follow the first approach and only three drivers have still the HAVE_xxx option (also HAVE_S3C2410_I2C and HAVE_S3C_RTC). I can update therefore the "depends" while removing the HAVE_S3C2410_WATCHDOG option or just keep it. Best regards, Krzysztof