* [v4,1/5] dt-binding: mediatek: watchdog: fix the description of compatible
2020-08-03 7:14 [v4,0/5] watchdog: mt8192: add wdt support Crystal Guo
@ 2020-08-03 7:14 ` Crystal Guo
2020-09-14 15:13 ` Guenter Roeck
2020-08-03 7:14 ` [v4,2/5] arm64: dts: mt8183: update watchdog device node Crystal Guo
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Crystal Guo @ 2020-08-03 7:14 UTC (permalink / raw)
To: linux, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang, Crystal Guo
The watchdog driver for MT2712 and MT8183 relies on DT data, so
the fallback compatible MT6589 won't work.
Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index 4dd36bd3f1ad..45eedc2c3141 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -4,13 +4,13 @@ Required properties:
- compatible should contain:
"mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
- "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
+ "mediatek,mt2712-wdt": for MT2712
"mediatek,mt6589-wdt": for MT6589
"mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
"mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
"mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
- "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
+ "mediatek,mt8183-wdt": for MT8183
"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
- reg : Specifies base physical address and size of the registers.
--
2.18.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [v4,1/5] dt-binding: mediatek: watchdog: fix the description of compatible
2020-08-03 7:14 ` [v4,1/5] dt-binding: mediatek: watchdog: fix the description of compatible Crystal Guo
@ 2020-09-14 15:13 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2020-09-14 15:13 UTC (permalink / raw)
To: Crystal Guo, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang
On 8/3/20 12:14 AM, Crystal Guo wrote:
> The watchdog driver for MT2712 and MT8183 relies on DT data, so
> the fallback compatible MT6589 won't work.
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index 4dd36bd3f1ad..45eedc2c3141 100644
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -4,13 +4,13 @@ Required properties:
>
> - compatible should contain:
> "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> - "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
> + "mediatek,mt2712-wdt": for MT2712
> "mediatek,mt6589-wdt": for MT6589
> "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> - "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
> + "mediatek,mt8183-wdt": for MT8183
> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>
> - reg : Specifies base physical address and size of the registers.
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [v4,2/5] arm64: dts: mt8183: update watchdog device node
2020-08-03 7:14 [v4,0/5] watchdog: mt8192: add wdt support Crystal Guo
2020-08-03 7:14 ` [v4,1/5] dt-binding: mediatek: watchdog: fix the description of compatible Crystal Guo
@ 2020-08-03 7:14 ` Crystal Guo
2020-09-14 15:14 ` Guenter Roeck
2020-09-21 16:58 ` Matthias Brugger
2020-08-03 7:14 ` [v4,3/5] dt-binding: mediatek: mt8192: update mtk-wdt document Crystal Guo
` (3 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Crystal Guo @ 2020-08-03 7:14 UTC (permalink / raw)
To: linux, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang, Crystal Guo
The watchdog driver for MT8183 relies on DT data, so the fallback
compatible MT6589 won't work, need to update watchdog device node
to sync with watchdog dt-binding document.
Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 1e03c849dc5d..f8d835746ab8 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -310,8 +310,7 @@
};
watchdog: watchdog@10007000 {
- compatible = "mediatek,mt8183-wdt",
- "mediatek,mt6589-wdt";
+ compatible = "mediatek,mt8183-wdt";
reg = <0 0x10007000 0 0x100>;
#reset-cells = <1>;
};
--
2.18.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [v4,2/5] arm64: dts: mt8183: update watchdog device node
2020-08-03 7:14 ` [v4,2/5] arm64: dts: mt8183: update watchdog device node Crystal Guo
@ 2020-09-14 15:14 ` Guenter Roeck
2020-09-21 16:58 ` Matthias Brugger
1 sibling, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2020-09-14 15:14 UTC (permalink / raw)
To: Crystal Guo, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang
On 8/3/20 12:14 AM, Crystal Guo wrote:
> The watchdog driver for MT8183 relies on DT data, so the fallback
> compatible MT6589 won't work, need to update watchdog device node
> to sync with watchdog dt-binding document.
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 1e03c849dc5d..f8d835746ab8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -310,8 +310,7 @@
> };
>
> watchdog: watchdog@10007000 {
> - compatible = "mediatek,mt8183-wdt",
> - "mediatek,mt6589-wdt";
> + compatible = "mediatek,mt8183-wdt";
> reg = <0 0x10007000 0 0x100>;
> #reset-cells = <1>;
> };
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [v4,2/5] arm64: dts: mt8183: update watchdog device node
2020-08-03 7:14 ` [v4,2/5] arm64: dts: mt8183: update watchdog device node Crystal Guo
2020-09-14 15:14 ` Guenter Roeck
@ 2020-09-21 16:58 ` Matthias Brugger
1 sibling, 0 replies; 13+ messages in thread
From: Matthias Brugger @ 2020-09-21 16:58 UTC (permalink / raw)
To: Crystal Guo, linux, robh+dt
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang
On 03/08/2020 09:14, Crystal Guo wrote:
> The watchdog driver for MT8183 relies on DT data, so the fallback
> compatible MT6589 won't work, need to update watchdog device node
> to sync with watchdog dt-binding document.
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
Applied to v5.9-next/dts64
Thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 1e03c849dc5d..f8d835746ab8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -310,8 +310,7 @@
> };
>
> watchdog: watchdog@10007000 {
> - compatible = "mediatek,mt8183-wdt",
> - "mediatek,mt6589-wdt";
> + compatible = "mediatek,mt8183-wdt";
> reg = <0 0x10007000 0 0x100>;
> #reset-cells = <1>;
> };
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [v4,3/5] dt-binding: mediatek: mt8192: update mtk-wdt document
2020-08-03 7:14 [v4,0/5] watchdog: mt8192: add wdt support Crystal Guo
2020-08-03 7:14 ` [v4,1/5] dt-binding: mediatek: watchdog: fix the description of compatible Crystal Guo
2020-08-03 7:14 ` [v4,2/5] arm64: dts: mt8183: update watchdog device node Crystal Guo
@ 2020-08-03 7:14 ` Crystal Guo
2020-08-03 7:15 ` [v4,4/5] dt-binding: mt8192: add toprgu reset-controller head file Crystal Guo
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Crystal Guo @ 2020-08-03 7:14 UTC (permalink / raw)
To: linux, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang, Crystal Guo
update mtk-wdt document for MT8192 platform
Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index 45eedc2c3141..e36ba60de829 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -12,6 +12,7 @@ Required properties:
"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
"mediatek,mt8183-wdt": for MT8183
"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
+ "mediatek,mt8192-wdt": for MT8192
- reg : Specifies base physical address and size of the registers.
--
2.18.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [v4,4/5] dt-binding: mt8192: add toprgu reset-controller head file
2020-08-03 7:14 [v4,0/5] watchdog: mt8192: add wdt support Crystal Guo
` (2 preceding siblings ...)
2020-08-03 7:14 ` [v4,3/5] dt-binding: mediatek: mt8192: update mtk-wdt document Crystal Guo
@ 2020-08-03 7:15 ` Crystal Guo
2020-09-14 15:15 ` Guenter Roeck
2020-08-03 7:15 ` [v4,5/5] watchdog: mt8192: add wdt support Crystal Guo
2020-09-11 3:26 ` [v4,0/5] " Nicolas Boichat
5 siblings, 1 reply; 13+ messages in thread
From: Crystal Guo @ 2020-08-03 7:15 UTC (permalink / raw)
To: linux, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang, Crystal Guo
add toprgu reset-controller head file for MT8192 platform
Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
.../reset-controller/mt8192-resets.h | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h
diff --git a/include/dt-bindings/reset-controller/mt8192-resets.h b/include/dt-bindings/reset-controller/mt8192-resets.h
new file mode 100644
index 000000000000..84fee34f1c32
--- /dev/null
+++ b/include/dt-bindings/reset-controller/mt8192-resets.h
@@ -0,0 +1,30 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2020 MediaTek Inc.
+ * Author: Yong Liang <yong.liang@mediatek.com>
+ */
+
+#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8192
+#define _DT_BINDINGS_RESET_CONTROLLER_MT8192
+
+#define MT8183_TOPRGU_MM_SW_RST 1
+#define MT8183_TOPRGU_MFG_SW_RST 2
+#define MT8183_TOPRGU_VENC_SW_RST 3
+#define MT8183_TOPRGU_VDEC_SW_RST 4
+#define MT8183_TOPRGU_IMG_SW_RST 5
+#define MT8183_TOPRGU_MD_SW_RST 7
+#define MT8183_TOPRGU_CONN_SW_RST 9
+#define MT8183_TOPRGU_CONN_MCU_SW_RST 12
+#define MT8183_TOPRGU_IPU0_SW_RST 14
+#define MT8183_TOPRGU_IPU1_SW_RST 15
+#define MT8183_TOPRGU_AUDIO_SW_RST 17
+#define MT8183_TOPRGU_CAMSYS_SW_RST 18
+#define MT8192_TOPRGU_MJC_SW_RST 19
+#define MT8192_TOPRGU_C2K_S2_SW_RST 20
+#define MT8192_TOPRGU_C2K_SW_RST 21
+#define MT8192_TOPRGU_PERI_SW_RST 22
+#define MT8192_TOPRGU_PERI_AO_SW_RST 23
+
+#define MT8192_TOPRGU_SW_RST_NUM 23
+
+#endif /* _DT_BINDINGS_RESET_CONTROLLER_MT8192 */
--
2.18.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [v4,4/5] dt-binding: mt8192: add toprgu reset-controller head file
2020-08-03 7:15 ` [v4,4/5] dt-binding: mt8192: add toprgu reset-controller head file Crystal Guo
@ 2020-09-14 15:15 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2020-09-14 15:15 UTC (permalink / raw)
To: Crystal Guo, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang
On 8/3/20 12:15 AM, Crystal Guo wrote:
> add toprgu reset-controller head file for MT8192 platform
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> .../reset-controller/mt8192-resets.h | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h
>
> diff --git a/include/dt-bindings/reset-controller/mt8192-resets.h b/include/dt-bindings/reset-controller/mt8192-resets.h
> new file mode 100644
> index 000000000000..84fee34f1c32
> --- /dev/null
> +++ b/include/dt-bindings/reset-controller/mt8192-resets.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2020 MediaTek Inc.
> + * Author: Yong Liang <yong.liang@mediatek.com>
> + */
> +
> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8192
> +#define _DT_BINDINGS_RESET_CONTROLLER_MT8192
> +
> +#define MT8183_TOPRGU_MM_SW_RST 1
> +#define MT8183_TOPRGU_MFG_SW_RST 2
> +#define MT8183_TOPRGU_VENC_SW_RST 3
> +#define MT8183_TOPRGU_VDEC_SW_RST 4
> +#define MT8183_TOPRGU_IMG_SW_RST 5
> +#define MT8183_TOPRGU_MD_SW_RST 7
> +#define MT8183_TOPRGU_CONN_SW_RST 9
> +#define MT8183_TOPRGU_CONN_MCU_SW_RST 12
> +#define MT8183_TOPRGU_IPU0_SW_RST 14
> +#define MT8183_TOPRGU_IPU1_SW_RST 15
> +#define MT8183_TOPRGU_AUDIO_SW_RST 17
> +#define MT8183_TOPRGU_CAMSYS_SW_RST 18
> +#define MT8192_TOPRGU_MJC_SW_RST 19
> +#define MT8192_TOPRGU_C2K_S2_SW_RST 20
> +#define MT8192_TOPRGU_C2K_SW_RST 21
> +#define MT8192_TOPRGU_PERI_SW_RST 22
> +#define MT8192_TOPRGU_PERI_AO_SW_RST 23
> +
> +#define MT8192_TOPRGU_SW_RST_NUM 23
> +
> +#endif /* _DT_BINDINGS_RESET_CONTROLLER_MT8192 */
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [v4,5/5] watchdog: mt8192: add wdt support
2020-08-03 7:14 [v4,0/5] watchdog: mt8192: add wdt support Crystal Guo
` (3 preceding siblings ...)
2020-08-03 7:15 ` [v4,4/5] dt-binding: mt8192: add toprgu reset-controller head file Crystal Guo
@ 2020-08-03 7:15 ` Crystal Guo
2020-09-14 15:12 ` Guenter Roeck
2020-09-11 3:26 ` [v4,0/5] " Nicolas Boichat
5 siblings, 1 reply; 13+ messages in thread
From: Crystal Guo @ 2020-08-03 7:15 UTC (permalink / raw)
To: linux, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang, Crystal Guo
Add support for watchdog device found in MT8192 SoC
Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/watchdog/mtk_wdt.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index d6a6393f609d..aef0c2db6a11 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -11,6 +11,7 @@
#include <dt-bindings/reset-controller/mt2712-resets.h>
#include <dt-bindings/reset-controller/mt8183-resets.h>
+#include <dt-bindings/reset-controller/mt8192-resets.h>
#include <linux/delay.h>
#include <linux/err.h>
#include <linux/init.h>
@@ -76,6 +77,10 @@ static const struct mtk_wdt_data mt8183_data = {
.toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM,
};
+static const struct mtk_wdt_data mt8192_data = {
+ .toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,
+};
+
static int toprgu_reset_update(struct reset_controller_dev *rcdev,
unsigned long id, bool assert)
{
@@ -322,6 +327,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
{ .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
{ .compatible = "mediatek,mt6589-wdt" },
{ .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
+ { .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);
--
2.18.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [v4,5/5] watchdog: mt8192: add wdt support
2020-08-03 7:15 ` [v4,5/5] watchdog: mt8192: add wdt support Crystal Guo
@ 2020-09-14 15:12 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2020-09-14 15:12 UTC (permalink / raw)
To: Crystal Guo, robh+dt, matthias.bgg
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, linux-kernel,
linux-watchdog, seiya.wang
On 8/3/20 12:15 AM, Crystal Guo wrote:
> Add support for watchdog device found in MT8192 SoC
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mtk_wdt.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index d6a6393f609d..aef0c2db6a11 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -11,6 +11,7 @@
>
> #include <dt-bindings/reset-controller/mt2712-resets.h>
> #include <dt-bindings/reset-controller/mt8183-resets.h>
> +#include <dt-bindings/reset-controller/mt8192-resets.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/init.h>
> @@ -76,6 +77,10 @@ static const struct mtk_wdt_data mt8183_data = {
> .toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM,
> };
>
> +static const struct mtk_wdt_data mt8192_data = {
> + .toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,
> +};
> +
> static int toprgu_reset_update(struct reset_controller_dev *rcdev,
> unsigned long id, bool assert)
> {
> @@ -322,6 +327,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
> { .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
> { .compatible = "mediatek,mt6589-wdt" },
> { .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
> + { .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [v4,0/5] watchdog: mt8192: add wdt support
2020-08-03 7:14 [v4,0/5] watchdog: mt8192: add wdt support Crystal Guo
` (4 preceding siblings ...)
2020-08-03 7:15 ` [v4,5/5] watchdog: mt8192: add wdt support Crystal Guo
@ 2020-09-11 3:26 ` Nicolas Boichat
2020-09-14 15:26 ` Guenter Roeck
5 siblings, 1 reply; 13+ messages in thread
From: Nicolas Boichat @ 2020-09-11 3:26 UTC (permalink / raw)
To: Guenter Roeck, Matthias Brugger
Cc: Rob Herring, srv_heupstream,
moderated list:ARM/Mediatek SoC support, linux-arm Mailing List,
lkml, linux-watchdog, seiya.wang, Crystal Guo
Matthias, Guenter,
These patches have all been reviewed (apart from fairly trivial 2/5),
which maintainer should be picking those up?
Thanks!
On Mon, Aug 3, 2020 at 3:15 PM Crystal Guo <crystal.guo@mediatek.com> wrote:
>
> v4 changes:
> revise commit messages.
>
> v3 changes:
> https://patchwork.kernel.org/patch/11692731/
> https://patchwork.kernel.org/patch/11692767/
> https://patchwork.kernel.org/patch/11692729/
> https://patchwork.kernel.org/patch/11692771/
> https://patchwork.kernel.org/patch/11692733/
>
> Crystal Guo (5):
> dt-binding: mediatek: watchdog: fix the description of compatible
> arm64: dts: mt8183: update watchdog device node
> dt-binding: mediatek: mt8192: update mtk-wdt document
> dt-binding: mt8192: add toprgu reset-controller head file
> watchdog: mt8192: add wdt support
>
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 5 ++--
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-
> drivers/watchdog/mtk_wdt.c | 6 ++++
> .../reset-controller/mt8192-resets.h | 30 +++++++++++++++++++
> 4 files changed, 40 insertions(+), 4 deletions(-)
> create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [v4,0/5] watchdog: mt8192: add wdt support
2020-09-11 3:26 ` [v4,0/5] " Nicolas Boichat
@ 2020-09-14 15:26 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2020-09-14 15:26 UTC (permalink / raw)
To: Nicolas Boichat, Matthias Brugger
Cc: Rob Herring, srv_heupstream,
moderated list:ARM/Mediatek SoC support, linux-arm Mailing List,
lkml, linux-watchdog, seiya.wang, Crystal Guo
On 9/10/20 8:26 PM, Nicolas Boichat wrote:
> Matthias, Guenter,
>
> These patches have all been reviewed (apart from fairly trivial 2/5),
> which maintainer should be picking those up?
>
I don't see an Acked-by or Reviewed-by from a DT maintainer.
We'll have to wait for feedback from Rob.
Thanks,
Guenter
> Thanks!
>
> On Mon, Aug 3, 2020 at 3:15 PM Crystal Guo <crystal.guo@mediatek.com> wrote:
>>
>> v4 changes:
>> revise commit messages.
>>
>> v3 changes:
>> https://patchwork.kernel.org/patch/11692731/
>> https://patchwork.kernel.org/patch/11692767/
>> https://patchwork.kernel.org/patch/11692729/
>> https://patchwork.kernel.org/patch/11692771/
>> https://patchwork.kernel.org/patch/11692733/
>>
>> Crystal Guo (5):
>> dt-binding: mediatek: watchdog: fix the description of compatible
>> arm64: dts: mt8183: update watchdog device node
>> dt-binding: mediatek: mt8192: update mtk-wdt document
>> dt-binding: mt8192: add toprgu reset-controller head file
>> watchdog: mt8192: add wdt support
>>
>> .../devicetree/bindings/watchdog/mtk-wdt.txt | 5 ++--
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-
>> drivers/watchdog/mtk_wdt.c | 6 ++++
>> .../reset-controller/mt8192-resets.h | 30 +++++++++++++++++++
>> 4 files changed, 40 insertions(+), 4 deletions(-)
>> create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h
>>
>>
^ permalink raw reply [flat|nested] 13+ messages in thread