Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Will Deacon" <will@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Li Yang" <leoyang.li@nxp.com>, "Han Xu" <han.xu@nxp.com>,
	"Frank Li" <frank.li@nxp.com>,
	"Fugang Duan" <fugang.duan@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 13/19] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles
Date: Tue, 25 Aug 2020 09:17:32 +0200
Message-ID: <20200825071732.GD3458@kozik-lap> (raw)
In-Reply-To: <20200825044653.GK13023@pengutronix.de>

On Tue, Aug 25, 2020 at 06:46:53AM +0200, Sascha Hauer wrote:
> On Mon, Aug 24, 2020 at 06:26:46PM +0200, Krzysztof Kozlowski wrote:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - fsl,imx6q-ocotp
> > +              - fsl,imx6sl-ocotp
> > +              - fsl,imx6sx-ocotp
> > +              - fsl,imx6ul-ocotp
> > +              - fsl,imx6ull-ocotp
> > +              - fsl,imx7d-ocotp
> > +              - fsl,imx6sll-ocotp
> > +              - fsl,imx7ulp-ocotp
> > +              - fsl,imx8mq-ocotp
> > +              - fsl,imx8mm-ocotp
> > +              - fsl,imx8mn-ocotp
> > +              - fsl,imx8mp-ocotp
> > +          - const: syscon
> > +      - items:
> > +          # The devices are not really compatible with fsl,imx8mm-ocotp, however
> > +          # the code for getting SoC revision depends on fsl,imx8mm-ocotp compatible.
> 
> Shouldn't this be fixed? It seems strange to justify a binding with
> existing code.

The fsl,imx8mn-ocotp is actually compatible with "mm", only the
fsl,imx8mp-ocotp is not (although someone might argue that subset of
"mp" falls into "mn").

The problem is that drivers/soc/imx/soc-imx8m.c checks revision only
against the fsl,imx8mm-ocotp compatible, not the others. It's the
pattern used in that driver also for other i.MX 8. Therefore it is a
binding implemented and actually used, regardless whether it is correct
from hardware point of view or not.

If that's preferred, I could adjust the drivers/soc/imx/soc-imx8m.c for
the incompatible "mp". It should not break anything.

Best regards,
Krzysztof


  reply index

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 16:26 [PATCH v2 01/19] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
2020-08-24 16:26 ` [PATCH v2 02/19] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property Krzysztof Kozlowski
2020-08-25  2:32   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 03/19] dt-bindings: gpio: fsl-imx-gpio: Add parsing of hogs Krzysztof Kozlowski
2020-08-25  2:33   ` Rob Herring
2020-08-25  2:41     ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 04/19] dt-bindings: gpio: fsl-imx-gpio: Add power-domains Krzysztof Kozlowski
2020-08-25  2:33   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 05/19] dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles Krzysztof Kozlowski
2020-08-25  2:33   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 06/19] dt-bindings: pwm: imx-pwm: " Krzysztof Kozlowski
2020-08-25  2:34   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 07/19] dt-bindings: serial: fsl-imx-uart: " Krzysztof Kozlowski
2020-08-25  2:34   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 08/19] dt-bindings: watchdog: fsl-imx-wdt: " Krzysztof Kozlowski
2020-08-25  2:35   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 09/19] dt-bindings: mtd: gpmi-nand: " Krzysztof Kozlowski
2020-08-25  2:35   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 10/19] dt-bindings: reset: fsl,imx7-src: " Krzysztof Kozlowski
2020-08-25  2:36   ` [PATCH v2 10/19] dt-bindings: reset: fsl, imx7-src: " Rob Herring
2020-08-24 16:26 ` [PATCH v2 11/19] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible Krzysztof Kozlowski
2020-08-25  2:36   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 12/19] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching Krzysztof Kozlowski
2020-08-25  2:38   ` Rob Herring
2020-08-25  7:08     ` Krzysztof Kozlowski
2020-08-24 16:26 ` [PATCH v2 13/19] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles Krzysztof Kozlowski
2020-08-25  2:39   ` Rob Herring
2020-08-25  7:19     ` Krzysztof Kozlowski
2020-08-25  4:46   ` Sascha Hauer
2020-08-25  7:17     ` Krzysztof Kozlowski [this message]
2020-08-24 16:26 ` [PATCH v2 14/19] dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding Krzysztof Kozlowski
2020-08-25  2:39   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 15/19] dt-bindings: arm: fsl: Add ZII Ultra boards binding Krzysztof Kozlowski
2020-08-25  2:40   ` Rob Herring
2020-08-24 16:26 ` [PATCH v2 16/19] dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching Krzysztof Kozlowski
2020-08-25  2:40   ` [PATCH v2 16/19] dt-bindings: interrupt-controller: fsl, irqsteer: " Rob Herring
2020-08-24 16:26 ` [PATCH v2 17/19] dt-bindings: serial: fsl-lpuart: " Krzysztof Kozlowski
2020-08-25  2:42   ` Rob Herring
2020-08-25  7:55     ` Krzysztof Kozlowski
2020-08-24 16:26 ` [PATCH v2 18/19] arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on Krzysztof Kozlowski
2020-08-24 16:26 ` [PATCH v2 19/19] arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs Krzysztof Kozlowski
2020-08-25  2:31 ` [PATCH v2 01/19] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825071732.GD3458@kozik-lap \
    --to=krzk@kernel.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@nxp.com \
    --cc=fugang.duan@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=leoyang.li@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git