From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E8EC43465 for ; Fri, 18 Sep 2020 17:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8036A21741 for ; Fri, 18 Sep 2020 17:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600450121; bh=Tai9b+dkc2OO/gjSjFBMZzWKgDSOcVSgsuIH5fwmn1E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QA0B4HYMbrxdGuxKxnN9ZQFDB7RurqUCmuaQbLd5joVxK6Mqnw+8HKmLJHHGuUcLI Ff49oeGWxv0io7ZIc39pm1m7VdbpdoN+HdpSKCMdNVP4QntXwEel8FjkLiTACn5Kgm NfIIIxwNJkNAf2lQTi31x0OeH6sv+1JfKEoAVD+k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbgIRR2h (ORCPT ); Fri, 18 Sep 2020 13:28:37 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:46213 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbgIRR2h (ORCPT ); Fri, 18 Sep 2020 13:28:37 -0400 Received: by mail-io1-f67.google.com with SMTP id g7so7614047iov.13; Fri, 18 Sep 2020 10:28:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z3/o4FNgT3sVWGBvsTBO0kcsZlWLlbzi8uqL4n57Vio=; b=nBfOtJFIVItVeDRm3RHEC8O+yJjG+CRO09sav4jTiNe9WK0uj37cWjyj7k03eW6yDK ORdSZ1EjbZGTlkBZFNcQ/sdeu+xr43N19MlOD6oEiNyg4UyqBb4bD8v5I0Qw3ydgxKdn x4bowMz1ZhugOXv1Fz69NW7tiCe9GcGDBqaJLwKpJ4UV5nrvgl3vTq3C6DUTGZd9c7Eh 5ZIJJGfIpNoNxr6CVYcDI/4vRPvZcVsximy+eHhAhcpHcFkGScqx8JouxilskPfZJnZ4 mo/m+v9fIyBP0m1Xk6ncLu2X120qEevkPTA/UD40evHsiPH9NOta1t7w8MeTFrfHDEQ1 trfw== X-Gm-Message-State: AOAM530YvFeyavX35wQV1oAFrYZQx3IIuvtAtjUF28e0JcqkhFfiP87F /zFGSp5bOLMDpBKiyPa3YqvSS+u5d5G9 X-Google-Smtp-Source: ABdhPJx7zWX4NVvoHSu+6LjlCGzyA40cyiahCuXULhm0IWxvYH195Oyh8k1z5O5i4rnSFwm/5FOkqw== X-Received: by 2002:a05:6638:1643:: with SMTP id a3mr31124880jat.4.1600450115841; Fri, 18 Sep 2020 10:28:35 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id f1sm1919631ilh.25.2020.09.18.10.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 10:28:35 -0700 (PDT) Received: (nullmailer pid 3826167 invoked by uid 1000); Fri, 18 Sep 2020 17:28:34 -0000 Date: Fri, 18 Sep 2020 11:28:34 -0600 From: Rob Herring To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Lee Jones , Liam Girdwood , Mark Brown , Wim Van Sebroeck , Guenter Roeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v1 1/6] dt_bindings: mfd: Add ROHM BD9576MUF and BD9573MUF PMICs Message-ID: <20200918172834.GA3819336@bogus> References: <434579d4cddf891f8fa0f50a152c098b113fa2fb.1600329307.git.matti.vaittinen@fi.rohmeurope.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <434579d4cddf891f8fa0f50a152c098b113fa2fb.1600329307.git.matti.vaittinen@fi.rohmeurope.com> Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Thu, Sep 17, 2020 at 11:01:52AM +0300, Matti Vaittinen wrote: > Add bindings for ROHM BD9576MUF and BD9573MUF PMICs. These > PMICs are primarily intended to be used to power the R-Car series > processors. They provide 6 power outputs, safety features and a > watchdog with two functional modes. > > Signed-off-by: Matti Vaittinen > --- > .../bindings/mfd/rohm,bd9576-pmic.yaml | 129 ++++++++++++++++++ > 1 file changed, 129 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd9576-pmic.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd9576-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd9576-pmic.yaml > new file mode 100644 > index 000000000000..f17d4d621585 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd9576-pmic.yaml > @@ -0,0 +1,129 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/rohm,bd9576-pmic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BD9576MUF and BD9573MUF Power Management Integrated Circuit bindings > + > +maintainers: > + - Matti Vaittinen > + > +description: | > + BD9576MUF and BD9573MUF are power management ICs primarily intended for > + powering the R-Car series processors. > + The IC provides 6 power outputs with configurable sequencing and safety > + monitoring. A watchdog logic with slow ping/windowed modes is also included. > + > +properties: > + compatible: > + enum: > + - rohm,bd9576 > + - rohm,bd9573 > + > + reg: > + description: > + I2C slave address. > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + rohm,vout1-en-low: > + description: > + BD9576 and BD9573 VOUT1 regulator enable state can be individually > + controlled by a GPIO. This is dictated by state of vout1-en pin during > + the PMIC startup. If vout1-en is LOW during PMIC startup then the VOUT1 > + enable sate is controlled via this pin. Set this property if vout1-en > + is wired to be down at PMIC start-up. > + type: boolean > + > + rohm,vout1-en-gpios: > + description: > + GPIO specifier to specify the GPIO connected to vout1-en for vout1 ON/OFF > + state control. > + maxItems: 1 > + > + rohm,ddr-sel-low: > + description: > + The BD9576 and BD9573 output voltage for DDR can be selected by setting > + the ddr-sel pin low or high. Set this property if ddr-sel is grounded. > + type: boolean > + > + rohm,watchdog-enable-gpios: > + description: The GPIO line used to enable the watchdog. > + maxItems: 1 > + > + rohm,watchdog-ping-gpios: > + description: The GPIO line used to ping the watchdog. > + maxItems: 1 > + > + hw_margin_ms: Needs a vendor prefix. s/_/-/ > + minimum: 4 > + maximum: 4416 > + description: Watchog timeout in milliseconds Maybe the words in the description should be in the property name as I don't see how 'h/w margin' relates to 'watchdog timeout'. Is this a max and below is the min?: > + > + rohm,hw-margin-min-ms: > + minimum: 2 > + maximum: 220 > + description: > + Watchdog on these ICs can be configured in a window mode where the ping > + must come within certain time-window. Eg. too quick pinging will also > + trigger timeout. Specify the minimum delay between pings if you wish to > + use the window mode. Note, the maximum delay is internally configured as > + a certain multiple of this value so maximum delay can be only up to 15 > + times this value. For example for 73 ms short ping value the maximum > + timeout will be close to 1 sec. > + > + regulators: > + $ref: ../regulator/rohm,bd9576-regulator.yaml > + description: > + List of child nodes that specify the regulators. > + > +required: > + - compatible > + - reg > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic: pmic@30 { > + compatible = "rohm,bd9576"; > + reg = <0x30>; > + rohm,vout1-en-low; > + rohm,vout1-en-gpios = <&gpio2 6 GPIO_ACTIVE_HIGH>; > + rohm,ddr-sel-low; > + rohm,watchdog-enable-gpios = <&gpio2 6 GPIO_ACTIVE_HIGH>; > + rohm,watchdog-ping-gpios = <&gpio2 7 GPIO_ACTIVE_HIGH>; > + hw_margin_ms = <30>; > + rohm,hw-margin-min-ms = <4>; > + > + regulators { > + boost1: regulator-vd50 { > + regulator-name = "VD50"; > + }; > + buck1: regulator-vd18 { > + regulator-name = "VD18"; > + }; > + buck2: regulator-vdddr { > + regulator-name = "vdddr"; > + }; > + buck3: regulator-vd10 { > + regulator-name = "vd10"; > + }; > + ldo: regulator-voutl1 { > + regulator-name = "VOUTL1"; > + }; > + sw: regulator-vouts1 { > + regulator-name = "VOUTS1"; > + }; > + }; > + }; > + }; > -- > 2.21.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]