From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D7BC47423 for ; Tue, 22 Sep 2020 02:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3087623A62 for ; Tue, 22 Sep 2020 02:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600743557; bh=b2qwnEFh+ba+rThRPVC7+mIXVik4Np6wC8ogIy5np/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=C6fcwUGu6vrykE5zml+rbFhoUKY48Cw52Z10Xk2rF9iLjUb5uZWbwbGlD/HWKNUmm EF1DfdnhKREgY31Bfb/0zr9v+IJ+nhFSbJVegcr7OjdBqI+fWSvxzyTgisWExVEJrU ofXP7gUyDwL5PTzZ+9i5wXgBhkkAcROENdx9DIP0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729089AbgIVC7P (ORCPT ); Mon, 21 Sep 2020 22:59:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:59904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728991AbgIVC7O (ORCPT ); Mon, 21 Sep 2020 22:59:14 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5A63F239A1; Tue, 22 Sep 2020 02:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600743554; bh=b2qwnEFh+ba+rThRPVC7+mIXVik4Np6wC8ogIy5np/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tkH+HRlJL6TKGegQlflvBRnj+TIfWuAQPjXVI8pWBtpZOXwhNMefqNKGTU0bpuMVw DD6Ga0B1wscRBHHGKEVoH5uyZqzR4yY2wu+W2k4UwMKfHbrxS9AtdUUgF6f1ZMGon/ YGWy+3a3BE7LVRfsD2XXyK7tnl3j5p/XgI+sKie8= Date: Tue, 22 Sep 2020 10:59:05 +0800 From: Shawn Guo To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko , Catalin Marinas , Will Deacon , Pavel Machek Subject: Re: [PATCH v10 11/13] arm64: dts: freescale: sl28: enable LED support Message-ID: <20200922025904.GX25109@dragon> References: <20200914214341.14268-1-michael@walle.cc> <20200914214341.14268-12-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200914214341.14268-12-michael@walle.cc> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Mon, Sep 14, 2020 at 11:43:39PM +0200, Michael Walle wrote: > Now that we have support for GPIO lines of the SMARC connector, enable > LED support on the KBox A-230-LS. There are two LEDs without fixed > functions, one is yellow and one is green. Unfortunately, it is just one > multi-color LED, thus while it is possible to enable both at the same > time it is hard to tell the difference between "yellow only" and "yellow > and green". > > Signed-off-by: Michael Walle > Acked-by: Pavel Machek > --- > Changes since v9: > - none > > Changes since v8: > - none > > Changes since v7: > - use new "function" and "color" properties instead of a label > - added default-on trigger for the power-led > > Changes since v6: > - none > > Changes since v5: > - changed the label, suggested by Pavel Machek > > Changes since v4: > - none > > Changes since v3: > - see cover letter > > .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > index 4b4cc6a1573d..dd516c0efd8b 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > @@ -11,11 +11,29 @@ > > /dts-v1/; > #include "fsl-ls1028a-kontron-sl28-var4.dts" > +#include > > / { > model = "Kontron KBox A-230-LS"; > compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var4", > "kontron,sl28", "fsl,ls1028a"; > + > + leds { > + compatible = "gpio-leds"; > + > + alarm-led { > + function = LED_FUNCTION_ALARM; > + color = ; > + gpios = <&sl28cpld_gpio0 0 0>; > + }; > + > + power-led { > + linux,default-trigger = "default-on"; > + function = LED_FUNCTION_POWER; > + color = ; > + gpios = <&sl28cpld_gpio1 3 0>; Use GPIO_ACTIVE_HIGH for polarity to improve the readability. I fixed them up and applied patch #9 ~ #13. Shawn > + }; > + }; > }; > > &enetc_mdio_pf3 { > -- > 2.20.1 >